From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17405C43381 for ; Thu, 21 Mar 2019 06:27:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E27A3218AE for ; Thu, 21 Mar 2019 06:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727756AbfCUG13 (ORCPT ); Thu, 21 Mar 2019 02:27:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:48526 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726012AbfCUG12 (ORCPT ); Thu, 21 Mar 2019 02:27:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8686AACF3; Thu, 21 Mar 2019 06:27:26 +0000 (UTC) Date: Thu, 21 Mar 2019 07:27:25 +0100 Message-ID: From: Takashi Iwai To: Kailang Cc: Jian-Hong Pan , "alsa-devel@alsa-project.org" , "Linux Upstreaming Team" , Linux Kernel Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286 In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A18DBA856@RTITMBSVM07.realtek.com.tw> References: <20190315095108.9195-1-jian-hong@endlessm.com> <6FAB7C47BCF00940BB0999A99BE3547A18DBA856@RTITMBSVM07.realtek.com.tw> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Mar 2019 03:37:33 +0100, Kailang wrote: > > Yes, you could use Reviewed-by. OK, applied now. Thanks. Takashi > > -----Original Message----- > From: Jian-Hong Pan > Sent: Wednesday, March 20, 2019 1:06 PM > To: Takashi Iwai > Cc: Kailang ; alsa-devel@alsa-project.org; Linux Upstreaming Team ; Linux Kernel > Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286 > > Takashi Iwai 於 2019年3月15日 週五 下午7:24寫道： > > > > On Fri, 15 Mar 2019 10:51:09 +0100, > > Jian-Hong Pan wrote: > > > > > > Some Acer AIO desktops like Veriton Z6860G, Z4860G and Z4660G cannot > > > record sound from headset MIC. This patch adds the > > > ALC286_FIXUP_ACER_AIO_HEADSET_MIC quirk to fix this issue. > > > > > > Signed-off-by: Jian-Hong Pan > > > --- > > > v2: According to Realtek's suggestion, change the COEF 0x4f from 0xd429 to > > > 0x5029. Thanks to Realtek! > > > > It'd be nicer if we get either Acked-by or Reviewed-by tag from > > Realtek. Kailang? > > Hi Kailang, > > May we have your Acked-by or Reviewed-by tag for this patch? > Signed-off will also be great! > > Thank you > Jian-Hong Pan > > > thanks, > > > > Takashi > > > > > > > > sound/pci/hda/patch_realtek.c | 17 ++++++++++++++--- > > > 1 file changed, 14 insertions(+), 3 deletions(-) > > > > > > diff --git a/sound/pci/hda/patch_realtek.c > > > b/sound/pci/hda/patch_realtek.c index 384719d5c44e..191830d4fa40 > > > 100644 > > > --- a/sound/pci/hda/patch_realtek.c > > > +++ b/sound/pci/hda/patch_realtek.c > > > @@ -5687,6 +5687,7 @@ enum { > > > ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE, > > > ALC225_FIXUP_WYSE_AUTO_MUTE, > > > ALC225_FIXUP_WYSE_DISABLE_MIC_VREF, > > > + ALC286_FIXUP_ACER_AIO_HEADSET_MIC, > > > }; > > > > > > static const struct hda_fixup alc269_fixups[] = { @@ -6685,6 > > > +6686,16 @@ static const struct hda_fixup alc269_fixups[] = { > > > .chained = true, > > > .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > > > }, > > > + [ALC286_FIXUP_ACER_AIO_HEADSET_MIC] = { > > > + .type = HDA_FIXUP_VERBS, > > > + .v.verbs = (const struct hda_verb[]) { > > > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x4f }, > > > + { 0x20, AC_VERB_SET_PROC_COEF, 0x5029 }, > > > + { } > > > + }, > > > + .chained = true, > > > + .chain_id = ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE > > > + }, > > > }; > > > > > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6701,9 > > > +6712,9 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > > SND_PCI_QUIRK(0x1025, 0x079b, "Acer Aspire V5-573G", ALC282_FIXUP_ASPIRE_V5_PINS), > > > SND_PCI_QUIRK(0x1025, 0x102b, "Acer Aspire C24-860", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE), > > > SND_PCI_QUIRK(0x1025, 0x106d, "Acer Cloudbook 14", ALC283_FIXUP_CHROME_BOOK), > > > - SND_PCI_QUIRK(0x1025, 0x128f, "Acer Veriton Z6860G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE), > > > - SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE), > > > - SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE), > > > + SND_PCI_QUIRK(0x1025, 0x128f, "Acer Veriton Z6860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > > + SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > > + SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", > > > + ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > > SND_PCI_QUIRK(0x1025, 0x1330, "Acer TravelMate X514-51T", ALC255_FIXUP_ACER_HEADSET_MIC), > > > SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), > > > SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", > > > ALC275_FIXUP_DELL_XPS), > > > -- > > > 2.20.1 > > > > > > > > ------Please consider the environment before printing this e-mail.