mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Ayman Bagabas <ayman.bagabas@gmail.com>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Hui Wang <hui.wang@canonical.com>,
	Andy Shevchenko <andy@infradead.org>,
	Darren Hart <dvhart@infradead.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Kailang Yang <kailang@realtek.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.
Date: Mon, 03 Dec 2018 15:22:20 +0100	[thread overview]
Message-ID: <s5hlg56y9k3.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAHp75Vf7WW8ezL_H_iw_=nSVARuvhugUY5sTkQ=usU96Wj2YSA@mail.gmail.com>

On Mon, 03 Dec 2018 15:18:54 +0100,
Andy Shevchenko wrote:
> 
> On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai <tiwai@suse.de> wrote:
> > On Fri, 30 Nov 2018 00:57:37 +0100,
> > Ayman Bagabas wrote:
> 
> > > +struct huawei_wmi_priv {
> > > +     struct input_dev *idev;
> > > +     struct led_classdev cdev;
> > > +     acpi_handle handle;
> >
> > Is this handle set in anywhere?  I couldn't see it in your patch.
> > If it's supposed to be NULL, passing NULL explicitly makes your
> > intention clearer.
> 
> Isn't below an answer?
> 
> > > +     // Skip registering LED subsystem if no ACPI method was found.
> > > +     status = acpi_get_handle(priv->handle, "\\_SB.PCI0.LPCB.EC0", &priv->handle);

Oh indeed, but why it passes priv->handle at the first argument...?


thanks,

Takashi

  reply	other threads:[~2018-12-03 14:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 23:57 [PATCH v8 0/3] Huawei laptops Ayman Bagabas
2018-11-29 23:57 ` [PATCH v8 1/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
2018-11-29 23:57 ` [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-12-03 12:00   ` Takashi Iwai
2018-12-03 14:18     ` Andy Shevchenko
2018-12-03 14:22       ` Takashi Iwai [this message]
2018-12-03 14:23         ` Andy Shevchenko
2018-12-03 15:46     ` ayman.bagabas
2018-12-03 15:51       ` Takashi Iwai
2018-12-03 14:22   ` Andy Shevchenko
2018-11-29 23:57 ` [PATCH v8 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas
2018-12-03 12:00   ` Takashi Iwai
2018-12-03 15:48     ` ayman.bagabas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlg56y9k3.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=ayman.bagabas@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=hui.wang@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®