From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751708AbdHXJib (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 05:38:31 -0400
Received: from mx2.suse.de ([195.135.220.15]:54764 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751260AbdHXJi3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 05:38:29 -0400
Date: Thu, 24 Aug 2017 11:38:27 +0200
Message-ID: <s5hlgm9l2zw.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>, Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Johannes Stezenbach <js@sig21.net>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Dollar Cove TI PMIC support for Intel Cherry Trail
In-Reply-To: <CAHp75VetbVbe15eCzuzyXHx-t-oWZDEEw4PLu4YKg94fvhpDmw@mail.gmail.com>
References: <20170824081141.5018-1-tiwai@suse.de>
        <CAHp75VetbVbe15eCzuzyXHx-t-oWZDEEw4PLu4YKg94fvhpDmw@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 24 Aug 2017 11:27:32 +0200,
Andy Shevchenko wrote:
> 
> On Thu, Aug 24, 2017 at 11:11 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > Hi,
> >
> > this is the revised patch set to add the support for Dollar Cove TI
> > PMIC found on some Intel Cherry Trail laptops / tablets.  All drivers
> > are based on the original code from Intel downstream patches, with
> > lots of rewrites and cleanups.  MFD driver is implemented as a
> > stand-alone like a few other variants, and the input driver got a diet
> > in a minimalistic form.
> >
> > The patch set has been tested on ASUS E100H and E200H, as well as on
> > HP x210.
> >
> > v1->v2:
> > - Minor cleanups in mfd driver code as suggested by Andy
> > - Move power-button driver to platform/x86, driver renames accordingly
> > - Add missing wake-irq cleanup to power-button driver
> > - get_raw_temp cleanup in opregion driver, mention about register
> >   endianess
> >
> >
> 
> Global comment to the series, we agreed with Hans to follow the
> pattern for Intel PMIC driver (module / file) names:
> 
> intel_XXX_<PLATFORM><PMIC>, where <PLATFORM> is 3 letter encoded Intel
> platform name, like cht for CherryTrail and <PMIC> is two letter
> abbreviation from ZZZ Cove, like wc for Whiskey Cove.
> 
> Here I understand that there is a potential of two PMIC variants for
> the same platform DC from Intel, DC from TI. I dunno if former will be
> a case in the future, though we may use something like
> 
>  intel_XXX_chtdc_ti
> 
> for the latter one.

Noted.

Also I forgot again to add Hans to Cc.  Will put him in the next
round.


thanks,

Takashi