From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941432AbcIZPoe (ORCPT ); Mon, 26 Sep 2016 11:44:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:45081 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbcIZPob (ORCPT ); Mon, 26 Sep 2016 11:44:31 -0400 Date: Mon, 26 Sep 2016 17:44:24 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Zefan Li , Tejun Heo Subject: Re: [PATCH 4.4 048/118] cpuset: make sure new tasks conform to the current config of the cpuset In-Reply-To: <20160926153822.GA1771@kroah.com> References: <20160922172938.643879685@linuxfoundation.org> <20160922172941.226931424@linuxfoundation.org> <20160926153822.GA1771@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Sep 2016 17:38:22 +0200, Greg Kroah-Hartman wrote: > > On Mon, Sep 26, 2016 at 02:34:33PM +0200, Takashi Iwai wrote: > > On Thu, 22 Sep 2016 19:29:08 +0200, > > Greg Kroah-Hartman wrote: > > > > > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Zefan Li > > > > > > commit 06f4e94898918bcad00cdd4d349313a439d6911e upstream. > > > > > > A new task inherits cpus_allowed and mems_allowed masks from its parent, > > > but if someone changes cpuset's config by writing to cpuset.cpus/cpuset.mems > > > before this new task is inserted into the cgroup's task list, the new task > > > won't be updated accordingly. > > > > > > Signed-off-by: Zefan Li > > > Signed-off-by: Tejun Heo > > > Signed-off-by: Greg Kroah-Hartman > > > > > > --- > > > kernel/cpuset.c | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > --- a/kernel/cpuset.c > > > +++ b/kernel/cpuset.c > > > @@ -2074,6 +2074,20 @@ static void cpuset_bind(struct cgroup_su > > > mutex_unlock(&cpuset_mutex); > > > } > > > > > > +/* > > > + * Make sure the new task conform to the current state of its parent, > > > + * which could have been changed by cpuset just after it inherits the > > > + * state from the parent and before it sits on the cgroup's task list. > > > + */ > > > +void cpuset_fork(struct task_struct *task) > > > > This causes a build warning: > > > > kernel/cpuset.c:2101:2: warning: (near initialization for 'cpuset_cgrp_subsys.fork') [enabled by default] > > .fork = cpuset_fork, > > ^ > > > > where fork op in 4.4 kernel has still priv argument that was dropped > > recently. > > Thanks, I have a patch in my tree already for this and it will show up > in the next release. Great, thanks! Takashi