mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Tommi Rantala <tt.rantala@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: sound/oss/ad1848.c:2867:32: warning: ‘id_table’ defined but not used
Date: Mon, 17 Jun 2013 09:56:34 +0200	[thread overview]
Message-ID: <s5hli69npal.wl%tiwai@suse.de> (raw)
In-Reply-To: <CA+ydwtrDxmywNPmJZqviYWNPUhati=Khq764cDN06uKKRo3xUQ@mail.gmail.com>

At Thu, 13 Jun 2013 18:23:02 +0300,
Tommi Rantala wrote:
> 
> Hello, I'm seeing the following compiler warning, does it look useful?
> I'm doing a v3.10-rc5 x86-64 build.
> 
> /build/linux/sound/oss/ad1848.c:2867:32: warning: ‘id_table’ defined
> but not used [-Wunused-variable]
> 
> $ gcc --version
> gcc (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
> Copyright (C) 2012 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> 
> config:
> http://fpaste.org/18443/13711363/

It's because CONFIG_ISAPNP isn't set (it's optional).  You can add
ifdef to hide the warning, but it makes the code uglier, OTOH.

Since this driver is a legacy one and almost no one uses it, better to
save your time for more useful things, I'd say :)


thanks,

Takashi

      reply	other threads:[~2013-06-17  7:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13 15:23 Tommi Rantala
2013-06-17  7:56 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hli69npal.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tt.rantala@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®