From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752141Ab2DQQcV (ORCPT ); Tue, 17 Apr 2012 12:32:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33858 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148Ab2DQQcT (ORCPT ); Tue, 17 Apr 2012 12:32:19 -0400 Date: Tue, 17 Apr 2012 18:32:18 +0200 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Ondrej Zary , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 3/4] Add Wolfson Microelectronics WM8776 codec ALSA driver In-Reply-To: <20120417161820.GP6652@opensource.wolfsonmicro.com> References: <1334611118-10301-1-git-send-email-linux@rainbow-software.org> <1334611118-10301-4-git-send-email-linux@rainbow-software.org> <20120417150234.GB22575@sirena.org.uk> <201204171813.44044.linux@rainbow-software.org> <20120417161820.GP6652@opensource.wolfsonmicro.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 17 Apr 2012 17:18:21 +0100, Mark Brown wrote: > > On Tue, Apr 17, 2012 at 06:13:40PM +0200, Ondrej Zary wrote: > > On Tuesday 17 April 2012 17:02:34 Mark Brown wrote: > > > > Same comments as the previous patch, this should be using ASoC. In this > > > case the device has in fact been supported in mainline since 2.6.32... > > > Yes, the driver is there - but I dont's see any way to use it. ASoC was not > > designed to be used with sound cards and nobody has ever used any ASoC driver > > in a sound card driver. I don't feel like breaking a working driver (with 16 > > subdrivers for many more card types). > > What makes you cleaim that "ASoC was not designed to be used with sound > cards"? Implementing sound cards is the sole purpose of ASoC... You don't need to overreact, he surely means only about the existing ice1724 sound driver for his device :) Restructuring ice1712 and ice1724 drivers to use ASoC would require quite a lot of works, and no one really wants it, I guess. Many boards are old and can't be tested easily. And, we still need to match the ASoC components with the controls of the current driver. This was already discussed a bit, and Clemens suggested like this way. thanks, Takashi