From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755438Ab0C3SDX (ORCPT <rfc822;w@1wt.eu>);
	Tue, 30 Mar 2010 14:03:23 -0400
Received: from cantor.suse.de ([195.135.220.2]:57915 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753612Ab0C3SDV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 30 Mar 2010 14:03:21 -0400
Date: Tue, 30 Mar 2010 20:03:20 +0200
Message-ID: <s5hljd91yc7.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
       LKML <linux-kernel@vger.kernel.org>, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH -next] sound: fix patch_realtek printk format
In-Reply-To: <4BB238ED.9040909@oracle.com>
References: <20100330191834.f2009292.sfr@canb.auug.org.au>
	<4BB238ED.9040909@oracle.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 30 Mar 2010 10:46:21 -0700,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix printk format warnings in patch_realtek.c:
> 
> ound/pci/hda/patch_realtek.c:5120: warning: format '%s' expects type 'char *', but argument 2 has type 'int'
> sound/pci/hda/patch_realtek.c:5120: warning: too few arguments for format
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc:	Jaroslav Kysela <perex@perex.cz>
> Cc:	Takashi Iwai <tiwai@suse.de>

Thanks, this was already fixed for tomorrow's merge.


Takashi

> ---
>  sound/pci/hda/patch_realtek.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-next-20100330.orig/sound/pci/hda/patch_realtek.c
> +++ linux-next-20100330/sound/pci/hda/patch_realtek.c
> @@ -5117,7 +5117,8 @@ static void fillup_priv_adc_nids(struct 
>  	}
>  	if (!spec->num_adc_nids) {
>  		printk(KERN_WARNING "hda_codec: %s: no valid ADC found;"
> -		       " using fallback 0x%x\n", fallback_adc);
> +		       " using fallback 0x%x\n",
> +		       codec->chip_name, fallback_adc);
>  		spec->private_adc_nids[0] = fallback_adc;
>  		spec->adc_nids = spec->private_adc_nids;
>  		if (fallback_adc != fallback_cap) {
>