From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752530AbYHRF0s (ORCPT ); Mon, 18 Aug 2008 01:26:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750924AbYHRF0k (ORCPT ); Mon, 18 Aug 2008 01:26:40 -0400 Received: from mail.suse.de ([195.135.220.2]:37948 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbYHRF0k (ORCPT ); Mon, 18 Aug 2008 01:26:40 -0400 Date: Mon, 18 Aug 2008 07:26:38 +0200 Message-ID: From: Takashi Iwai To: Sam Ravnborg Cc: Jeff Mahoney , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kbuild: Fix creation of include2/asm symlink In-Reply-To: <20080817183714.GA18976@uranus.ravnborg.org> References: <20080815194954.GA18377@uranus.ravnborg.org> <20080817183714.GA18976@uranus.ravnborg.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 17 Aug 2008 20:37:14 +0200, Sam Ravnborg wrote: > > On Sat, Aug 16, 2008 at 11:03:51AM +0200, Takashi Iwai wrote: > > At Fri, 15 Aug 2008 21:49:54 +0200, > > Sam Ravnborg wrote: > > > > > > On Fri, Aug 15, 2008 at 03:45:58PM +0200, Takashi Iwai wrote: > > > > The directory include2/asm can point wrongly to a non-existing > > > > directory on architectures that have moved include/asm under arch/*. > > > > > > > > This patch fixes it by checking firstly whether arch/*/include/asm is > > > > available. > > > > > > Hi Takashi. > > > > > > I understand why you try to avoid include2/asm as it is not pretty. > > > And I had a similar patch once - but I dropped it as the symlink do > > > not harm and it will anyway be gone when the remaining architectures > > > has shifted to use arch/$ARCH/include/... > > > > > > So I will not apply it. > > > > Hm, OK. Originally I fixed it because our build system has a sanity > > check against bogus symlinks and refused to package the latest kernel. > > If you don't want to put it in, we can keep it locally, of course. > > But, a bogus symlink is definitely not pretty... > > It will go away as soon as all architextures are moved to use arch/$ARCH/include Yes, if it's removed, then that's fine, of course. But I wonder whether this will be finished during 2.6.27...? thanks, Takashi