Re: [PATCH] alsa: fix comparison of unsigned < 0

[Takashi Iwai <tiwai@suse.de>]

At Wed, 30 May 2007 13:47:44 +0200,
Jiri Slaby wrote:
> 
> Takashi Iwai napsal(a):
> > Hi,
> > 
> > thanks for checking this.
> > They seem actually hitting some real bugs.
> 
> Bug fixes are ok, but keep on your mind this (I haven't checked if this is
> the case):
> http://lkml.org/lkml/2006/11/28/206

Yep, I already committed real bugfixes but didn't apply the rest.


thanks,

Takashi

> 
> > At Wed, 30 May 2007 03:35:54 -0400,
> > Bill Nottingham wrote:
> >> diff -ru linux-2.6.21-old/sound/pci/ac97/ac97_patch.c linux-2.6.21/sound/pci/ac97/ac97_patch.c
> >> --- linux-2.6.21-old/sound/pci/ac97/ac97_patch.c	2007-05-30 02:53:05.000000000 -0400
> >> +++ linux-2.6.21/sound/pci/ac97/ac97_patch.c	2007-05-30 02:32:41.000000000 -0400
> >> @@ -2086,8 +2086,7 @@
> >>  	struct snd_ac97 *ac97 = snd_kcontrol_chip(kcontrol);
> >>  	unsigned short val;
> >>  
> >> -	if (ucontrol->value.enumerated.item[0] > 3
> >> -	    || ucontrol->value.enumerated.item[0] < 0)
> >> +	if (ucontrol->value.enumerated.item[0] > 3)
> >>  		return -EINVAL;
> >>  	val = ctrl2reg[ucontrol->value.enumerated.item[0]]
> >>  	      << AC97_AD198X_VREF_SHIFT;
> > 
> > This one is fine.
> [...]
> 
> regards,
> -- 
> http://www.fi.muni.cz/~xslaby/            Jiri Slaby
> faculty of informatics, masaryk university, brno, cz
> e-mail: jirislaby gmail com, gpg pubkey fingerprint:
>  B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
>