From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753203AbXDQJ7P (ORCPT ); Tue, 17 Apr 2007 05:59:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753225AbXDQJ7P (ORCPT ); Tue, 17 Apr 2007 05:59:15 -0400 Received: from mx1.suse.de ([195.135.220.2]:53125 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753203AbXDQJ7N (ORCPT ); Tue, 17 Apr 2007 05:59:13 -0400 Date: Tue, 17 Apr 2007 11:59:12 +0200 Message-ID: From: Takashi Iwai To: bainonline@gmail.com Cc: perex@suse.cz, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] [ALSA] Add first generation macbook subsystem ID In-Reply-To: <46244dbb.7672bd23.37b9.00c5@mx.google.com> References: <46244dbb.7672bd23.37b9.00c5@mx.google.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 17 Apr 2007 10:01:47 +0530, bainonline@gmail.com wrote: > > From: Abhijit Bhopatkar > > First generation MacBooks were getting ignored by sigmatel drivers > and wrongly being identified as MACMINI. This patch makes them > identify as MACBOOK. > > Signed-off-by: Abhijit Bhopatkar This actually doesn't change behavior at all (both mac mini and mac book use the same pin configs), but it's still nice to add ID if any specific fix would be needed in future. Applied to ALSA tree now. Thanks. Takashi > --- > sound/pci/hda/patch_sigmatel.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c > index c94291b..cb99df5 100644 > --- a/sound/pci/hda/patch_sigmatel.c > +++ b/sound/pci/hda/patch_sigmatel.c > @@ -1905,6 +1905,9 @@ static int patch_stac922x(struct hda_codec *codec) > */ > printk(KERN_INFO "hda_codec: STAC922x, Apple subsys_id=%x\n", codec->subsystem_id); > switch (codec->subsystem_id) { > + case 0x106b0a00: /* MacBook First generatoin */ > + spec->board_config = STAC_MACBOOK; > + break; > case 0x106b0200: /* MacBook Pro first generation */ > spec->board_config = STAC_MACBOOK_PRO_V1; > break; > -- > 1.4.4.2 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >