From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A511C433F5 for ; Thu, 9 Sep 2021 07:34:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 552AF61101 for ; Thu, 9 Sep 2021 07:34:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352659AbhIIHgH (ORCPT ); Thu, 9 Sep 2021 03:36:07 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:49280 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232549AbhIIHgG (ORCPT ); Thu, 9 Sep 2021 03:36:06 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 5AE04201C0; Thu, 9 Sep 2021 07:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1631172896; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=93ENBNGr9bc7Gl7Ki4FE4D/A5edi5qVwM4LPjh0BVPc=; b=GbyyMUoDfeBoPfWfzXhdlGXu7YVdDONVtpLetNbm8436j0ygOEuSWuHlR/ktwi95HFePoL jdgNlx85nVOcY/zijxqDrVlDi96FIIkFfwZFExyT0ZUaNATfDGrY8Y16EnoMhydgh+XMQM DY8ZZca3hIe1Y3u69OlB6O55BafRO38= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1631172896; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=93ENBNGr9bc7Gl7Ki4FE4D/A5edi5qVwM4LPjh0BVPc=; b=T7pmCS6reb8Tv8W84aCEHUc3XflupMgpojPeWsbrrhH3OnaevMQL7uZc9Uou7zi8Z9e7gv kFc9JFH+nQMJeOAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 447DFA3B96; Thu, 9 Sep 2021 07:34:56 +0000 (UTC) Date: Tue, 07 Sep 2021 07:16:21 +0200 Message-ID: From: Takashi Iwai To: Tong Zhang Cc: Jaroslav Kysela , Takashi Iwai , Leon Romanovsky , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] ALSA: vx222: fix null-ptr-deref In-Reply-To: <20210907014746.1445278-1-ztong0001@gmail.com> References: <20210907014746.1445278-1-ztong0001@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Sep 2021 03:47:45 +0200, Tong Zhang wrote: > > a recent refactor created a null pointer vx in snd_vx222_probe(). > The vx pointer should have been populated in snd_vx222_create() as > suggested in earlier version, otherwise vx->core.ibl.size will throw an > error. > > [ 1.298398] BUG: kernel NULL pointer dereference, address: 00000000000001d8 > [ 1.316799] RIP: 0010:snd_vx222_probe+0x155/0x290 [snd_vx222] > > Fixes: 3bde3359aa16 ("ALSA: vx222: Allocate resources with device-managed APIs") > Signed-off-by: Tong Zhang Thanks, applied. Takashi