From: Takashi Iwai <tiwai@suse.de>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: isa: Fix inconsistent indenting
Date: Fri, 16 Apr 2021 12:39:11 +0200 [thread overview]
Message-ID: <s5hmttyqzsg.wl-tiwai@suse.de> (raw)
In-Reply-To: <1618567198-5120-1-git-send-email-yang.lee@linux.alibaba.com>
On Fri, 16 Apr 2021 11:59:58 +0200,
Yang Li wrote:
>
> Kernel test robot throws below warning ->
>
> smatch warnings:
> sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn:
> inconsistent indenting
> sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn:
> inconsistent indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> sound/isa/opti9xx/opti92x-ad1848.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
> index 08e61d9..234f023 100644
> --- a/sound/isa/opti9xx/opti92x-ad1848.c
> +++ b/sound/isa/opti9xx/opti92x-ad1848.c
> @@ -188,7 +188,7 @@ static int snd_opti9xx_init(struct snd_opti9xx *chip,
> chip->mc_base_size = opti9xx_mc_size[hardware];
> }
> #else
> - chip->mc_base_size = opti9xx_mc_size[hardware];
> + chip->mc_base_size = opti9xx_mc_size[hardware];
> #endif
No, it's not correct.
The ifdef is a bit tricky here but the line you changed belongs
to the else section.
thanks,
Takashi
prev parent reply other threads:[~2021-04-16 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 9:59 Yang Li
2021-04-16 10:39 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmttyqzsg.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®