From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B8FC433DB for ; Thu, 25 Feb 2021 09:37:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B79264EC3 for ; Thu, 25 Feb 2021 09:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236550AbhBYJg4 (ORCPT ); Thu, 25 Feb 2021 04:36:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:47890 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232923AbhBYJd1 (ORCPT ); Thu, 25 Feb 2021 04:33:27 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9E5EDACCF; Thu, 25 Feb 2021 09:32:45 +0000 (UTC) Date: Thu, 25 Feb 2021 10:32:45 +0100 Message-ID: From: Takashi Iwai To: Chris Chiu Cc: tiwai@suse.com, kailang@realtek.com, jhp@endlessos.org, kai.heng.feng@canonical.com, hui.wang@canonical.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable MICs of Acer SWIFT with ALC256 In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Feb 2021 10:21:07 +0100, Chris Chiu wrote: > > The Acer SWIFT Swift SF314-54/55 with ALC256 cannot detect the headset > microphone and suffers the noise problem in audio capture. > > This patch enables the headset jack sense and fixes the noise problem with > aamix fixup. > > Signed-off-by: Chris Chiu The patch seems broken due to the line break and cannot be applied cleanly. Could you resubmit? thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 290645516313..57e4dbcd76a9 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6372,6 +6372,8 @@ enum { > ALC236_FIXUP_DELL_AIO_HEADSET_MIC, > ALC282_FIXUP_ACER_DISABLE_LINEOUT, > ALC255_FIXUP_ACER_LIMIT_INT_MIC_BOOST, > + ALC256_FIXUP_ACER_SWIFT_NO_MIC_PRESENCE, > + ALC256_FIXUP_ACER_SWIFT_DISABLE_AAMIX, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -7815,6 +7817,22 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC255_FIXUP_ACER_MIC_NO_PRESENCE, > }, > + [ALC256_FIXUP_ACER_SWIFT_NO_MIC_PRESENCE] = { > + .type = HDA_FIXUP_PINS, > + .v.pins = (const struct hda_pintbl[]) { > + { 0x19, 0x02a1113c }, /* use as headset mic, > without its own jack detect */ > + { 0x1a, 0x90a1092f }, /* use as internal mic */ > + { }, > + }, > + .chained = true, > + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > + }, > + [ALC256_FIXUP_ACER_SWIFT_DISABLE_AAMIX] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_disable_aamix, > + .chained = true, > + .chain_id = ALC256_FIXUP_ACER_SWIFT_NO_MIC_PRESENCE > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -7841,9 +7859,11 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1025, 0x1246, "Acer Predator Helios 500", > ALC299_FIXUP_PREDATOR_SPK), > SND_PCI_QUIRK(0x1025, 0x1247, "Acer vCopperbox", > ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS), > SND_PCI_QUIRK(0x1025, 0x1248, "Acer Veriton N4660G", > ALC269VC_FIXUP_ACER_MIC_NO_PRESENCE), > + SND_PCI_QUIRK(0x1025, 0x1269, "Acer SWIFT SF314-54", > ALC256_FIXUP_ACER_SWIFT_DISABLE_AAMIX), > SND_PCI_QUIRK(0x1025, 0x128f, "Acer Veriton Z6860G", > ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", > ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", > ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > + SND_PCI_QUIRK(0x1025, 0x129c, "Acer SWIFT SF314-55", > ALC256_FIXUP_ACER_SWIFT_DISABLE_AAMIX), > SND_PCI_QUIRK(0x1025, 0x1308, "Acer Aspire Z24-890", > ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x132a, "Acer TravelMate B114-21", > ALC233_FIXUP_ACER_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x1330, "Acer TravelMate X514-51T", > ALC255_FIXUP_ACER_HEADSET_MIC), > -- > 2.20.1 >