From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FD06C433E1 for ; Wed, 19 Aug 2020 14:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED7B92083B for ; Wed, 19 Aug 2020 14:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728671AbgHSOxT (ORCPT ); Wed, 19 Aug 2020 10:53:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:55190 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726899AbgHSOxT (ORCPT ); Wed, 19 Aug 2020 10:53:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2BC63AD71; Wed, 19 Aug 2020 14:53:44 +0000 (UTC) Date: Wed, 19 Aug 2020 16:53:17 +0200 Message-ID: From: Takashi Iwai To: Sameer Pujar Cc: , , , , , , , Subject: Re: [PATCH] ALSA: hda: avoid reset of sdo_limit In-Reply-To: <1597848273-25813-1-git-send-email-spujar@nvidia.com> References: <1597848273-25813-1-git-send-email-spujar@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2020 16:44:33 +0200, Sameer Pujar wrote: > > By default 'sdo_limit' is initialized with a default value of '8' > as per spec. This is overridden in cases where a different value is > required. However this is getting reset when snd_hdac_bus_init_chip() > is called again, which happens during runtime PM cycle. Avoid reset > by not initializing to default value everytime. > > Fixes: 67ae482a59e9 ("ALSA: hda: add member to store ratio for stripe control") > Cc: > Signed-off-by: Sameer Pujar How about to move the default sdo_limit setup into snd_hdac_bus_init() instead? That's the place to be called only once. thanks, Takashi > --- > sound/hda/hdac_controller.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c > index 011b17c..0e26e96 100644 > --- a/sound/hda/hdac_controller.c > +++ b/sound/hda/hdac_controller.c > @@ -538,7 +538,8 @@ bool snd_hdac_bus_init_chip(struct hdac_bus *bus, bool full_reset) > * { ((num_channels * bits_per_sample * rate/48000) / > * number of SDOs) >= 8 } > */ > - bus->sdo_limit = 8; > + if (!bus->sdo_limit) > + bus->sdo_limit = 8; > > return true; > } > -- > 2.7.4 >