From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8040EC43381 for ; Mon, 1 Apr 2019 18:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 561A2206BA for ; Mon, 1 Apr 2019 18:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729713AbfDARI6 (ORCPT ); Mon, 1 Apr 2019 13:08:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:45284 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729323AbfDARIv (ORCPT ); Mon, 1 Apr 2019 13:08:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7DF4AABF4; Mon, 1 Apr 2019 17:08:50 +0000 (UTC) Date: Mon, 01 Apr 2019 19:08:49 +0200 Message-ID: From: Takashi Iwai To: "Jian-Hong Pan" Cc: , "Daniel Drake" , , "Kailang Yang" , Subject: Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233 In-Reply-To: <20190401032503.2821-1-jian-hong@endlessm.com> References: <20190401032503.2821-1-jian-hong@endlessm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 01 Apr 2019 05:25:05 +0200, Jian-Hong Pan wrote: > > The Acer TravelMate B114-21 laptop cannot detect and record sound from > headset MIC. This patch adds the ALC233_FIXUP_ACER_HEADSET_MIC HDA verb > quirk chained with ALC233_FIXUP_ASUS_MIC_NO_PRESENCE pin quirk to fix > this issue. > > Signed-off-by: Jian-Hong Pan > Signed-off-by: Daniel Drake > --- > sound/pci/hda/patch_realtek.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index a3fb3d4c5730..bdb2227be4eb 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5690,6 +5690,7 @@ enum { > ALC286_FIXUP_ACER_AIO_HEADSET_MIC, > ALC256_FIXUP_ASUS_MIC_NO_PRESENCE, > ALC299_FIXUP_PREDATOR_SPK, > + ALC233_FIXUP_ACER_HEADSET_MIC, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -6713,6 +6714,15 @@ static const struct hda_fixup alc269_fixups[] = { > { 0x21, 0x90170150 }, /* use as headset mic, without its own jack detect */ > { } > } > + [ALC233_FIXUP_ACER_HEADSET_MIC] = { > + .type = HDA_FIXUP_VERBS, > + .v.verbs = (const struct hda_verb[]) { > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x45 }, > + { 0x20, AC_VERB_SET_PROC_COEF, 0x5089 }, > + { } For the additional COEF application, I'd like to hear ack from Kailang. It's still a black magic from Realtek, so need some confirmation. thanks, Takashi > + }, > + .chained = true, > + .chain_id = ALC233_FIXUP_ASUS_MIC_NO_PRESENCE > }, > }; > > @@ -6737,6 +6747,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x1308, "Acer Aspire Z24-890", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > + SND_PCI_QUIRK(0x1025, 0x132a, "Acer TravelMate B114-21", ALC233_FIXUP_ACER_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x1330, "Acer TravelMate X514-51T", ALC255_FIXUP_ACER_HEADSET_MIC), > SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), > SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", ALC275_FIXUP_DELL_XPS), > -- > 2.20.1 > >