From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08281C64EB4 for ; Sat, 1 Dec 2018 14:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7A272081D for ; Sat, 1 Dec 2018 14:44:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7A272081D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbeLBB5b (ORCPT ); Sat, 1 Dec 2018 20:57:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:54202 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726458AbeLBB5b (ORCPT ); Sat, 1 Dec 2018 20:57:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 32831AE69; Sat, 1 Dec 2018 14:44:50 +0000 (UTC) Date: Sat, 01 Dec 2018 15:44:48 +0100 Message-ID: From: Takashi Iwai To: Jeremy Cline Cc: Kailang Yang , Jaroslav Kysela , Tim Van den Eynde , alsa-devel@alsa-project.org, Linux Kernel Mailing List Subject: Re: Regression: very quiet speakers on Thinkpad T570s In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Nov 2018 17:51:33 +0100, Jeremy Cline wrote: > > On 11/30/18 11:00 AM, Takashi Iwai wrote: > > On Fri, 30 Nov 2018 15:49:17 +0100, > > Jeremy Cline wrote: > >> > >> Hi, > >> > >> Some folks have reported on the Fedora bug tracker[0] that the laptop > >> speaker volume is very low on the Thinkpad T570 when running a kernel > >> that includes commit 61fcf8ece9b6 ("ALSA: hda/realtek - Enable Thinkpad > >> Dock device for ALC298 platform"). > >> > >> alsa-info.sh from v4.15.4 (just before commit 61fcf8ece9b6 arrived in > >> stable) and v4.19.4 with the issue present are attached to the bugzilla. > >> I've also Cc'd Tim, who uploaded them and has the laptop in question. > >> > >> [0] https://bugzilla.redhat.com/show_bug.cgi?id=1554304 > > > > Could you pinpoint which kernel version started showing the > > regression, at least? The diffs are fairly wide between 4.15 and > > 4.19. > > Ah, sorry for not being more clear. The regression appears to be > introduced by commit 61fcf8ece9b6, which got backported to v4.15.5 > because it addressed a bug with the dock[0]. v4.19.4 with that commit > reverted works, according to the bug reporter. > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=195161 OK, then this seems to be the change of DAC assignment. Maybe the hardware has some implicit assumption of NID 0x03 bound with the speaker pin. Below is a patch for fixing the pin / DAC mapping. Please give it a try. thanks, Takashi --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 06f93032d0cc..50bc2e97d799 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4988,9 +4988,14 @@ static void alc_fixup_tpt470_dock(struct hda_codec *codec, { 0x19, 0x21a11010 }, /* dock mic */ { } }; + static hda_nid_t preferred_pairs[] = { + 0x14, 0x03, 0x17, 0x02, 0x21, 0x02, + 0 + }; struct alc_spec *spec = codec->spec; if (action == HDA_FIXUP_ACT_PRE_PROBE) { + spec->gen.preferred_dacs = preferred_pairs; spec->parse_flags = HDA_PINCFG_NO_HP_FIXUP; snd_hda_apply_pincfgs(codec, pincfgs); } else if (action == HDA_FIXUP_ACT_INIT) {