mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
	<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: fix spelling mistake "Frequence" -> "Frequency"
Date: Mon, 26 Nov 2018 09:27:30 +0100	[thread overview]
Message-ID: <s5hmupw6y6l.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181125231208.14350-1-colin.king@canonical.com>

On Mon, 26 Nov 2018 00:12:08 +0100,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> There are spelling mistakes in equalizer name fields, fix them.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

In general, it's not good to rename the control names even if they are
fixes.  But these are rather device-specific ones, and they are EQ's,
which aren't too fatal to change, so I took it as-is now.


thanks,

Takashi


> ---
>  sound/usb/mixer_us16x08.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
> index 26ed23b18b77..4f594f9552a8 100644
> --- a/sound/usb/mixer_us16x08.c
> +++ b/sound/usb/mixer_us16x08.c
> @@ -1119,7 +1119,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
>  		.control_id = SND_US16X08_ID_EQLOWFREQ,
>  		.type = USB_MIXER_U8,
>  		.num_channels = 16,
> -		.name = "EQ Low Frequence",
> +		.name = "EQ Low Frequency",
>  	},
>  	{ /* EQ mid low gain */
>  		.kcontrol_new = &snd_us16x08_eq_gain_ctl,
> @@ -1133,7 +1133,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
>  		.control_id = SND_US16X08_ID_EQLOWMIDFREQ,
>  		.type = USB_MIXER_U8,
>  		.num_channels = 16,
> -		.name = "EQ MidLow Frequence",
> +		.name = "EQ MidLow Frequency",
>  	},
>  	{ /* EQ mid low Q */
>  		.kcontrol_new = &snd_us16x08_eq_mid_width_ctl,
> @@ -1154,7 +1154,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
>  		.control_id = SND_US16X08_ID_EQHIGHMIDFREQ,
>  		.type = USB_MIXER_U8,
>  		.num_channels = 16,
> -		.name = "EQ MidHigh Frequence",
> +		.name = "EQ MidHigh Frequency",
>  	},
>  	{ /* EQ mid high Q */
>  		.kcontrol_new = &snd_us16x08_eq_mid_width_ctl,
> @@ -1175,7 +1175,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
>  		.control_id = SND_US16X08_ID_EQHIGHFREQ,
>  		.type = USB_MIXER_U8,
>  		.num_channels = 16,
> -		.name = "EQ High Frequence",
> +		.name = "EQ High Frequency",
>  	},
>  };
>  
> -- 
> 2.19.1
> 
> 

  reply	other threads:[~2018-11-26  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25 23:12 Colin King
2018-11-26  8:27 ` Takashi Iwai [this message]
2020-10-02  9:18   ` Jaroslav Kysela
2020-10-02  9:26     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmupw6y6l.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®