From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53444FD21E1 for ; Mon, 30 Jul 2018 16:10:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0221F20890 for ; Mon, 30 Jul 2018 16:10:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0221F20890 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731633AbeG3RqS (ORCPT ); Mon, 30 Jul 2018 13:46:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:54398 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726784AbeG3RqS (ORCPT ); Mon, 30 Jul 2018 13:46:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3A4FEAE8E; Mon, 30 Jul 2018 16:10:37 +0000 (UTC) Date: Mon, 30 Jul 2018 18:10:37 +0200 Message-ID: From: Takashi Iwai To: Jorge Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] ALSA: usb-audio: Initial Power Domain support In-Reply-To: References: <20180719112215.4219-1-jorge.sanjuan@codethink.co.uk> <20180730092336.18741-1-jorge.sanjuan@codethink.co.uk> <20180730092336.18741-2-jorge.sanjuan@codethink.co.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Jul 2018 18:05:47 +0200, Jorge wrote: > > > > On 30/07/18 14:03, Takashi Iwai wrote: > > On Mon, 30 Jul 2018 11:23:33 +0200, > > Jorge Sanjuan wrote: > >> > >> diff --git a/include/linux/usb/audio-v3.h b/include/linux/usb/audio-v3.h > >> index 334bfa6dfb47..786e5939d831 100644 > >> --- a/include/linux/usb/audio-v3.h > >> +++ b/include/linux/usb/audio-v3.h > >> @@ -447,4 +447,8 @@ struct uac3_interrupt_data_msg { > >> /* BADD sample rate is always fixed to 48kHz */ > >> #define UAC3_BADD_SAMPLING_RATE 48000 > >> > >> +/* BADD power domains recovery times */ > >> +#define UAC3_BADD_PD_RECOVER_D1D0 0x0258 > >> +#define UAC3_BADD_PD_RECOVER_D2D0 0x1770 > > > > Please put the unit for these values. I guess they don't need to be > > hex? > > > > Hi! > > The BADD spec defines these inferred values as hex (see section 6.2.2.13 > of the spec). Should we keep them as per spec to avoid confusion? I'll > update comment there with the units (50 us increments). Well, if they were defined in hex, it makes sense to keep the raw values as is. But it'd be also helpful to give a comment showing the actual usecs. thanks, Takashi