From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932639AbeBLHYd (ORCPT ); Mon, 12 Feb 2018 02:24:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:59265 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932584AbeBLHYb (ORCPT ); Mon, 12 Feb 2018 02:24:31 -0500 Date: Mon, 12 Feb 2018 08:24:30 +0100 Message-ID: From: Takashi Iwai To: Lassi Ylikojola Cc: alsa-devel@alsa-project.org, arvind.yadav.cs@gmail.com, bhumirks@gmail.com, perex@perex.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204 In-Reply-To: <95a0b1fe-24e3-e902-8452-0b28c2c95315@gmail.com> References: <0132cbb2-34f8-b85c-383d-d639d938c836@gmail.com> <95a0b1fe-24e3-e902-8452-0b28c2c95315@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Feb 2018 15:51:36 +0100, Lassi Ylikojola wrote: > > Add quirk to ensure a sync endpoint is properly configured. > This patch is a fix for same symptoms on Behringer UFX1204 as patch > from Albertto Aquirre on Dec 8 2016 for Axe-Fx II. > Resending. Seems that there is a difference between git diff/commit versions 2.7.4 and 2.14.3. > I had to insert a line break with 2.4.13 to align properly(hopefully). Hrm, still some mess with the embedded patch, but never mind, I fixed manually and applied to my tree. But at the next time if you resend a patch, please refresh completely, not continuing a thread with "Re:" to the subject. Maybe you can try git-send-email at the next time. thanks, Takashi > > Signed-off-by: Lassi Ylikojola > --- > sound/usb/pcm.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index b9c9a19f9588..116a6ccc5b31 100644 > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c > @@ -357,6 +357,16 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs, > > alts = &iface->altsetting[1]; > goto add_sync_ep; > + case USB_ID(0x1397, 0x0002): > + ep = 0x81; > + iface = usb_ifnum_to_if(dev, 1); > + > + if (!iface || iface->num_altsetting == 0) > + return -EINVAL; > + > + alts = &iface->altsetting[1]; > + goto add_sync_ep; > + > > } > if (attr == USB_ENDPOINT_SYNC_ASYNC && > -- > 2.14.3 >