From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751853AbdGAGGw (ORCPT <rfc822;w@1wt.eu>);
        Sat, 1 Jul 2017 02:06:52 -0400
Received: from mx2.suse.de ([195.135.220.15]:51838 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751370AbdGAGGv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 1 Jul 2017 02:06:51 -0400
Date: Sat, 01 Jul 2017 08:06:49 +0200
Message-ID: <s5hmv8o4rnq.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
In-Reply-To: <20170630223423.GA20635@embeddedgus>
References: <20170630223423.GA20635@embeddedgus>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 01 Jul 2017 00:34:23 +0200,
Gustavo A. R. Silva wrote:
> 
> platform_get_irq() returns an error code, but the ac97c
> driver ignores it and always returns -ENXIO. This is not correct,
> and prevents -EPROBE_DEFER from being propagated properly.
> Notice that platform_get_irq() no longer returns 0 on error.
> 
> Print and propagate the return value of platform_get_irq on failure.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Applied, thanks.


Takashi