From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965187AbcBDKq7 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Feb 2016 05:46:59 -0500
Received: from mx2.suse.de ([195.135.220.15]:54852 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756174AbcBDKqr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Feb 2016 05:46:47 -0500
Date: Thu, 04 Feb 2016 11:46:42 +0100
Message-ID: <s5hmvrgg3cd.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Mauro Carvalho Chehab" <mchehab@osg.samsung.com>
Cc: "Shuah Khan" <shuahkh@osg.samsung.com>, <geliangtang@163.com>,
        <alsa-devel@alsa-project.org>, <arnd@arndb.de>,
        <ricard.wanderlof@axis.com>, <hans.verkuil@cisco.com>,
        <labbott@fedoraproject.org>, <chehabrafael@gmail.com>,
        <klock.android@gmail.com>, <misterpib@gmail.com>,
        <prabhakar.csengg@gmail.com>, <ricardo.ribalda@gmail.com>,
        <ruchandani.tina@gmail.com>, <takamichiho@gmail.com>,
        <tvboxspy@gmail.com>, <dominic.sacre@gmx.de>,
        <laurent.pinchart@ideasonboard.com>, <crope@iki.fi>, <julian@jusst.de>,
        <clemens@ladisch.de>, <pierre-louis.bossart@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <corbet@lwn.net>, <joe@oampo.co.uk>,
        <johan@oljud.se>, <dan.carpenter@oracle.com>, <pawel@osciak.com>,
        <javier@osg.samsung.com>, <p.zabel@pengutronix.de>, <perex@perex.cz>,
        <stefanr@s5r6.in-berlin.de>, <inki.dae@samsung.com>,
        <j.anaszewski@samsung.com>, <jh1009.sung@samsung.com>,
        <k.kozlowski@samsung.com>, <kyungmin.park@samsung.com>,
        <m.szyprowski@samsung.com>, <nenggun.kim@samsung.com>,
        <sw0312.kim@samsung.com>, <elfring@users.sourceforge.net>,
        <linux-api@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-media@vger.kernel.org>, <linuxbugs@vittgam.net>,
        <gtmkramer@xs4all.nl>, <normalperson@yhbt.net>, <daniel@zonque.org>
Subject: Re: [PATCH v2 21/22] sound/usb: Use Media Controller API to share media resources
In-Reply-To: <20160204083600.334a43f9@recife.lan>
References: <cover.1454557589.git.shuahkh@osg.samsung.com>
	<d6f619a817d94d4485dba566a4ba5f89a3667808.1454557589.git.shuahkh@osg.samsung.com>
	<20160204083600.334a43f9@recife.lan>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 04 Feb 2016 11:36:00 +0100,
Mauro Carvalho Chehab wrote:
> 
> > diff --git a/sound/usb/card.h b/sound/usb/card.h
> > index 71778ca..c15a03c 100644
> > --- a/sound/usb/card.h
> > +++ b/sound/usb/card.h
> > @@ -156,6 +156,7 @@ struct snd_usb_substream {
> >  	} dsd_dop;
> >  
> >  	bool trigger_tstamp_pending_update; /* trigger timestamp being updated from initial estimate */
> > +	void *media_ctl;
> >  };
> 
> This is Takashi's call, but I would prefer to avoid using a void *
> here. Fortunately, GCC is smart enough to handle struct pointers
> even if the header doesn't have a full declaration of the struct.
> 
> So, I would change the above to:
> 
> struct media_device;
> 
> struct snd_usb_substream {
> ...
> 	struct media_device *media_ctl;
> };
> 
> This way, we ensure strong typecast checks when compiling the code under
> sound/usb/media.c, while not needing to include media_device.h header here.

Agreed, this is no big merit to make it a void pointer.


Takashi