From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751774AbbAKQES (ORCPT ); Sun, 11 Jan 2015 11:04:18 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35286 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751063AbbAKQER (ORCPT ); Sun, 11 Jan 2015 11:04:17 -0500 Date: Sun, 11 Jan 2015 17:04:15 +0100 Message-ID: From: Takashi Iwai To: Rickard Strandqvist Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: ice1712: wm8766: Remove some unused functions In-Reply-To: <1420990300-19672-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1420990300-19672-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 11 Jan 2015 16:31:40 +0100, Rickard Strandqvist wrote: > > Removes some functions that are not used anywhere: > snd_wm8766_set_power() snd_wm8766_set_master_mode() > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist Applied, thanks. Takashi > --- > sound/pci/ice1712/wm8766.c | 16 ---------------- > sound/pci/ice1712/wm8766.h | 2 -- > 2 files changed, 18 deletions(-) > > diff --git a/sound/pci/ice1712/wm8766.c b/sound/pci/ice1712/wm8766.c > index 21b373b..f7ac8d5 100644 > --- a/sound/pci/ice1712/wm8766.c > +++ b/sound/pci/ice1712/wm8766.c > @@ -183,22 +183,6 @@ void snd_wm8766_set_if(struct snd_wm8766 *wm, u16 dac) > snd_wm8766_write(wm, WM8766_REG_IFCTRL, val | dac); > } > > -void snd_wm8766_set_master_mode(struct snd_wm8766 *wm, u16 mode) > -{ > - u16 val = wm->regs[WM8766_REG_DACCTRL3] & ~WM8766_DAC3_MSTR_MASK; > - > - mode &= WM8766_DAC3_MSTR_MASK; > - snd_wm8766_write(wm, WM8766_REG_DACCTRL3, val | mode); > -} > - > -void snd_wm8766_set_power(struct snd_wm8766 *wm, u16 power) > -{ > - u16 val = wm->regs[WM8766_REG_DACCTRL3] & ~WM8766_DAC3_POWER_MASK; > - > - power &= WM8766_DAC3_POWER_MASK; > - snd_wm8766_write(wm, WM8766_REG_DACCTRL3, val | power); > -} > - > void snd_wm8766_volume_restore(struct snd_wm8766 *wm) > { > u16 val = wm->regs[WM8766_REG_DACR1]; > diff --git a/sound/pci/ice1712/wm8766.h b/sound/pci/ice1712/wm8766.h > index c119f84..18c8d9d 100644 > --- a/sound/pci/ice1712/wm8766.h > +++ b/sound/pci/ice1712/wm8766.h > @@ -155,8 +155,6 @@ struct snd_wm8766 { > void snd_wm8766_init(struct snd_wm8766 *wm); > void snd_wm8766_resume(struct snd_wm8766 *wm); > void snd_wm8766_set_if(struct snd_wm8766 *wm, u16 dac); > -void snd_wm8766_set_master_mode(struct snd_wm8766 *wm, u16 mode); > -void snd_wm8766_set_power(struct snd_wm8766 *wm, u16 power); > void snd_wm8766_volume_restore(struct snd_wm8766 *wm); > int snd_wm8766_build_controls(struct snd_wm8766 *wm); > > -- > 1.7.10.4 >