mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [emu10k1]: remove the kcallloc cast (reported from make coccicheck's drop_kmalloc_cast.cocci)
Date: Fri, 25 May 2012 08:04:56 +0200	[thread overview]
Message-ID: <s5hmx4w7q47.wl%tiwai@suse.de> (raw)
In-Reply-To: <1337868149-17783-1-git-send-email-devendra.aaru@gmail.com>

At Thu, 24 May 2012 19:32:29 +0530,
Devendra Naga wrote:
> 
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>

I don't think removing it improves anything much.
It's cast to __user pointer, and this rather helps to catch the
caution.


thanks,

Takashi

> ---
>  sound/pci/emu10k1/emufx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
> index dae4050..272f8ac 100644
> --- a/sound/pci/emu10k1/emufx.c
> +++ b/sound/pci/emu10k1/emufx.c
> @@ -1815,7 +1815,7 @@ static int __devinit _snd_emu10k1_init_efx(struct snd_emu10k1 *emu)
>  
>  	if ((icode = kzalloc(sizeof(*icode), GFP_KERNEL)) == NULL)
>  		return -ENOMEM;
> -	if ((icode->gpr_map = (u_int32_t __user *)
> +	if ((icode->gpr_map =
>  	     kcalloc(256 + 160 + 160 + 2 * 512, sizeof(u_int32_t),
>  		     GFP_KERNEL)) == NULL ||
>              (controls = kcalloc(SND_EMU10K1_GPR_CONTROLS,
> -- 
> 1.7.9.5
> 

      reply	other threads:[~2012-05-25  6:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 14:02 Devendra Naga
2012-05-25  6:04 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmx4w7q47.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=devendra.aaru@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®