From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754075Ab1HGPrf (ORCPT ); Sun, 7 Aug 2011 11:47:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53900 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753661Ab1HGPrf (ORCPT ); Sun, 7 Aug 2011 11:47:35 -0400 Date: Sun, 07 Aug 2011 17:47:33 +0200 Message-ID: From: Takashi Iwai To: stufever@gmail.com Cc: linux-kernel@vger.kernel.org, Wang Shaoyan Subject: Re: [PATCH] Don't use the deprecated function check_region In-Reply-To: <1312644557-16772-1-git-send-email-wangshaoyan.pt@taobao.com> References: <1312644557-16772-1-git-send-email-wangshaoyan.pt@taobao.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 6 Aug 2011 23:29:17 +0800, stufever@gmail.com wrote: > > From: Wang Shaoyan > > sound/oss/pss.c: In function 'configure_nonsound_components': > sound/oss/pss.c:676: warning: 'check_region' is deprecated (declared at include/linux/ioport.h:201) > > --- > sound/oss/pss.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/oss/pss.c b/sound/oss/pss.c > index 9b800ce..b8ff41a 100644 > --- a/sound/oss/pss.c > +++ b/sound/oss/pss.c > @@ -673,7 +673,7 @@ static void configure_nonsound_components(void) > > if (pss_cdrom_port == -1) { /* If cdrom port enablation wasn't requested */ > printk(KERN_INFO "PSS: CDROM port not enabled.\n"); > - } else if (check_region(pss_cdrom_port, 2)) { > + } else if (check_mem_region(pss_cdrom_port, 2)) { It's no memory region, so this conversion doesn't look correct. The right fix would be to change the driver to actually manage the resources. thanks, Takashi