From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1759600AbZLOKmA@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759600AbZLOKmA (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2009 05:42:00 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759424AbZLOKl6
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 15 Dec 2009 05:41:58 -0500
Received: from cantor2.suse.de ([195.135.220.15]:54538 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757721AbZLOKl5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2009 05:41:57 -0500
Date: Tue, 15 Dec 2009 11:41:56 +0100
Message-ID: <s5hmy1kiknf.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Alex Chiang <achiang@hp.com>, linux-kernel <linux-kernel@vger.kernel.org>,
       linux-input@vger.kernel.org
Subject: Re: synaptics touchpad doesn't click
In-Reply-To: <20091215082518.GD12669@core.coreip.homeip.net>
References: <20091214014828.GA28402@ldl.fc.hp.com>
	<20091214173450.GB2373@core.coreip.homeip.net>
	<20091215034127.GC587@ldl.fc.hp.com>
	<20091215062628.GA12669@core.coreip.homeip.net>
	<s5h1viwn3ig.wl%tiwai@suse.de>
	<20091215073358.GC12669@core.coreip.homeip.net>
	<s5hvdg8lm5q.wl%tiwai@suse.de>
	<20091215082518.GD12669@core.coreip.homeip.net>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 15 Dec 2009 00:25:18 -0800,
Dmitry Torokhov wrote:
> 
> Indeed, we need to keep the state in synaptics now, thanks for noticing.
> The updated patch is below.

Also, one minor thing I noticed:

> -	if (SYN_CAP_MIDDLE_BUTTON(priv->capabilities)) {
> -		hw->middle = (buf[0] ^ buf[3]) & 0x01;
> -		hw->scroll = hw->w == 2 ? (signed char)buf[1] : 0;
> +		if (click && y < YMIN_NOMINAL) {

In my original patch, the position reporting in the button area is
disabled no matter whether clicked or not.  This was intentional
because I find it quite annoying that the mouse pointer moves slightly
when I click.  I often missed the target when I pressed strongly,
because my finger slipped a millimeter before the click state got
active.

This is a matter of taste, though.


> +			/*
> +			 * User pressed in ClickZone; report new button
> +			 * state but use :w

It's not in "w" field...


thanks,

Takashi