From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbZKAK0i (ORCPT ); Sun, 1 Nov 2009 05:26:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751422AbZKAK0h (ORCPT ); Sun, 1 Nov 2009 05:26:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51360 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbZKAK0f (ORCPT ); Sun, 1 Nov 2009 05:26:35 -0500 Date: Sun, 01 Nov 2009 11:26:39 +0100 Message-ID: From: Takashi Iwai To: Rusty Russell Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Ville Syrjala , Dmitry Torokhov , Alessandro Rubini , Michal Januszewski , Trond Myklebust , "J. Bruce Fields" , Neil Brown , linux-input@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/8] param: use ops in struct kernel_param, rather than get and set fns directly In-Reply-To: <200910302143.40268.rusty@rustcorp.com.au> References: <20091022142337.EC4A85362F@mx1.suse.de> <200910302143.40268.rusty@rustcorp.com.au> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 30 Oct 2009 21:43:39 +1030, Rusty Russell wrote: > > On Fri, 30 Oct 2009 08:48:12 pm Takashi Iwai wrote: > > At Fri, 23 Oct 2009 00:51:28 +1030, > > Rusty Russell wrote: > > > > > > This is more kernel-ish, saves some space, and also allows us to > > > expand the ops without breaking all the callers who are happy for the > > > new members to be NULL. > > > > > > The few places which defined their own param types are changed to the > > > new scheme. > > > > > > Since we're touching them anyway, we change get and set to take a > > > const struct kernel_param (which they were, and will be again). > > > > > > To reduce churn, module_param_call creates the ops struct so the callers > > > don't have to change (and casts the functions to reduce warnings). > > > The modern version which takes an ops struct is called module_param_cb. > > > > This is nice, as it also reduces the size of struct kernel_param, so > > each parameter uses less footprint (who cares, though?) :) > > > > But, just wondering whether we still need to export get/set > > functions. They can be called from ops now, so if any, it can be > > defined even as an inlinefunction or a macro. > > My thought too, so I tried that, but many are still used like so: > > module_param_call(foo, set_foo, param_get_uint, NULL, 0644); > > They can all be replaced in time with something like: > static int param_get_foo(char *buffer, const struct kernel_param *kp) > { > return param_ops_uint.get(buffer, kp); > } > > But it'll take a transition period. Fair enough. And, maybe these get/set should be defined as an ops explicitly so that it can be used for multiple parameters. But we can do cleanups later, of course :) Oh, in case you need, Reviewed-by: Takashi Iwai for all new patches. Thanks! Takashi