From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1752885AbYIBJlq@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752885AbYIBJlq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Sep 2008 05:41:46 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751134AbYIBJlj
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 2 Sep 2008 05:41:39 -0400
Received: from ns.suse.de ([195.135.220.2]:56509 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751121AbYIBJli (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Sep 2008 05:41:38 -0400
Date: Tue, 02 Sep 2008 11:41:36 +0200
Message-ID: <s5hmyiqkhpr.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Cai, Cliff" <Cliff.Cai@analog.com>
Cc: "Bryan Wu" <cooloney@kernel.org>, <perex@perex.cz>,
       <liam.girdwood@wolfsonmicro.com>, <broonie@opensource.wolfsonmicro.com>,
       <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] ALSA: add dummy function to support shared mmap in nommu Blackfin arch
In-Reply-To: <0F1B54C89D5F954D8535DB252AF412FA029D5EC2@chinexm1.ad.analog.com>
References: <1219829968-6431-1-git-send-email-cooloney@kernel.org>
	<1219829968-6431-5-git-send-email-cooloney@kernel.org>
	<s5h4p559umn.wl%tiwai@suse.de>
	<0F1B54C89D5F954D8535DB252AF412FA029D5EC2@chinexm1.ad.analog.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 2 Sep 2008 11:16:37 +0800,
Cai, Cliff wrote:
> 
>  
> > @@ -3419,5 +3426,6 @@ const struct file_operations snd_pcm_f_ops[2] =
> {
> >  		.compat_ioctl = 	snd_pcm_ioctl_compat,
> >  		.mmap =			snd_pcm_mmap,
> >  		.fasync =		snd_pcm_fasync,
> > +		.get_unmapped_area =	dummy_get_unmapped_area,
> >  	}
> >  };
> 
> >I don't think adding this dummy get_unmapped_area unconditionally for
> every driver is good.  This overrides the default
> >mm->get_unmaped_area.
> But without this dummy function,shared mmap on nommu arch would
> fail,refer to validate_mmap_request() in mm/nommu.c.

Yes, I know it's needed for nommu.  That's why I wrote
"unconditionally" in the above.

> May be we can add a kernel config item to include or not include this
> function depending on non-mmu or mmu arch.  

Checking CONFIG_MMU may suffice?


Takashi