From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1750824AbWEBJso@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750824AbWEBJso (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 2 May 2006 05:48:44 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751230AbWEBJsn
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 2 May 2006 05:48:43 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52181 "EHLO mx2.suse.de")
	by vger.kernel.org with ESMTP id S1750824AbWEBJsn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 May 2006 05:48:43 -0400
Date: Tue, 02 May 2006 11:48:31 +0200
Message-ID: <s5hmze0zrio.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Greg KH <greg@kroah.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       henne@nachtwindheim.de
Subject: Re: [ALSA] add __devinitdata to all pci_device_id
In-Reply-To: <20060501165443.GA9441@kroah.com>
References: <200605011511.k41FBUcu025025@hera.kernel.org>
	<1146502164.20760.53.camel@laptopd505.fenrus.org>
	<20060501165443.GA9441@kroah.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25)
 (eggplant) (+CVS-20060326) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 1 May 2006 09:54:43 -0700,
Greg KH wrote:
> 
> On Mon, May 01, 2006 at 06:49:24PM +0200, Arjan van de Ven wrote:
> > On Mon, 2006-05-01 at 15:11 +0000, Linux Kernel Mailing List wrote:
> > > commit 396c9b928d5c24775846a161a8191dcc1ea4971f
> > > tree 447f4b28c2dd8e0026b96025fb94dbc654d6cade
> > > parent 71b2ccc3a2fd6c27e3cd9b4239670005978e94ce
> > > author Henrik Kretzschmar <henne@nachtwindheim.de> Mon, 24 Apr 2006 15:59:04 +0200
> > > committer Jaroslav Kysela <perex@suse.cz> Thu, 27 Apr 2006 21:10:34 +0200
> > > 
> > > [ALSA] add __devinitdata to all pci_device_id
> > 
> > 
> > are you really really sure you want to do this?
> > These structures are exported via sysfs for example, I would think this
> > is quite the wrong thing to make go away silently...
> 
> I asked Henrik to not do this, but oh well...
> 
> No, if they are marked __devinit, and CONFIG_HOTPLUG is enabled, then
> the sysfs stuff is enabled.  And since CONFIG_HOTPLUG is pretty much
> always enabled these days, the savings of this kind of patch is
> non-existant...

Then actually what could be a pitfall by adding __devinitdata to
pci_device_id table?  If there is a potential danger, we should remove
these modifiers from all places, especially from
Documentation/pci.txt.


thanks,

Takashi