From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262002AbVG0IxJ (ORCPT ); Wed, 27 Jul 2005 04:53:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262007AbVG0IxJ (ORCPT ); Wed, 27 Jul 2005 04:53:09 -0400 Received: from cantor.suse.de ([195.135.220.2]:2513 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S262002AbVG0IxI (ORCPT ); Wed, 27 Jul 2005 04:53:08 -0400 Date: Wed, 27 Jul 2005 10:53:01 +0200 Message-ID: From: Takashi Iwai To: "Rafael J. Wysocki" Cc: LKML , ACPI mailing list , Andrew Morton , alsa-devel@alsa-project.org Subject: Re: [Alsa-devel] [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2) In-Reply-To: <200507261251.48291.rjw@sisk.pl> References: <200507261247.05684.rjw@sisk.pl> <200507261251.48291.rjw@sisk.pl> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta18) (chestnut) (+CVS-20041021) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 26 Jul 2005 12:51:47 +0200, Rafael J. Wysocki wrote: > > The following patch adds free_irq() and request_irq() to the suspend and > resume, respectively, routines in the snd_intel8x0 driver. The patch looks OK to me although I have some concerns. - The error in resume can't be handled properly. What should we do for the error of request_irq()? - Adding this to all drivers seem too much. We just need to stop the irq processing until resume, so something like suspend_irq(irq, dev_id) and resume_irq(irq, dev_id) would be more uesful? Takashi