From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAF0C433E2 for ; Mon, 31 Aug 2020 09:48:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A54AB206EB for ; Mon, 31 Aug 2020 09:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbgHaJse (ORCPT ); Mon, 31 Aug 2020 05:48:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:32864 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgHaJsc (ORCPT ); Mon, 31 Aug 2020 05:48:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 28A06AEC7; Mon, 31 Aug 2020 09:49:06 +0000 (UTC) Date: Mon, 31 Aug 2020 11:48:30 +0200 Message-ID: From: Takashi Iwai To: Dinghao Liu Cc: kjlu@umn.edu, Jaroslav Kysela , Takashi Iwai , "Gustavo A. R. Silva" , Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: opti9xx: Fix memleak in snd_opti9xx_read_check In-Reply-To: <20200829080517.22182-1-dinghao.liu@zju.edu.cn> References: <20200829080517.22182-1-dinghao.liu@zju.edu.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 29 Aug 2020 10:05:15 +0200, Dinghao Liu wrote: > > When request_region() on chip->res_mc_indir fails, > chip->res_mc_base should be freed to prevent memleak. > > Signed-off-by: Dinghao Liu The resources are freed automatically at private_free callback (snd_card_opti9xx_free()) called via snd_card_free() in the error path, hence this patch would lead to double-free. thanks, Takashi > --- > sound/isa/opti9xx/opti92x-ad1848.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c > index 881d3b5711d2..06ba18d1737c 100644 > --- a/sound/isa/opti9xx/opti92x-ad1848.c > +++ b/sound/isa/opti9xx/opti92x-ad1848.c > @@ -679,8 +679,11 @@ static int snd_opti9xx_read_check(struct snd_opti9xx *chip) > #else /* OPTi93X */ > chip->res_mc_indir = request_region(chip->mc_indir_index, 2, > "OPTi93x MC"); > - if (chip->res_mc_indir == NULL) > + if (chip->res_mc_indir == NULL) { > + release_and_free_resource(chip->res_mc_base); > + chip->res_mc_base = NULL; > return -EBUSY; > + } > > spin_lock_irqsave(&chip->lock, flags); > outb(chip->password, chip->mc_base + chip->pwd_reg); > -- > 2.17.1 >