From: Takashi Iwai <tiwai@suse.de>
To: Sameer Pujar <spujar@nvidia.com>
Cc: <perex@perex.cz>, <tiwai@suse.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <linux-tegra@vger.kernel.org>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<sharadg@nvidia.com>, <mkumard@nvidia.com>,
<viswanathl@nvidia.com>, <rlokhande@nvidia.com>,
<dramesh@nvidia.com>, <atalambedu@nvidia.com>
Subject: Re: [PATCH 0/3] Tegra194 HW Fixes
Date: Mon, 04 May 2020 10:29:14 +0200 [thread overview]
Message-ID: <s5ho8r4f6hx.wl-tiwai@suse.de> (raw)
In-Reply-To: <1588580176-2801-1-git-send-email-spujar@nvidia.com>
On Mon, 04 May 2020 10:16:13 +0200,
Sameer Pujar wrote:
>
> This series proposes SW workarounds for Tegra194 HDA HW bugs.
> Following are the two issues seen:
> 1. GCAP register does not reflect true capability.
> The actual number of SDO lines is "4", where as it reflects "2".
> 2. With 4 SDO line configuration playback fails for,
> 44.1K/48K, 2-channel, 16-bps audio stream.
>
> After fixing [1], issue [2] is uncovered.
> As per recommendation by Tegra HW team the workarounds are pushed.
>
> Testing done
> ============
> * Verify GCAP register after registering HDA sound card
> * Verify audio playback for 44.1K/48K, 2-channel, 16-bps.
>
> Sameer Pujar (3):
> ALSA: hda/tegra: correct number of SDO lines for Tegra194
> ALSA: hda: add member to store ratio for stripe control
> ALSA: hda/tegra: workaround playback failure on Tegra194
Through a quick glance, all changes look good.
Is the device already in market, i.e. it had hit users? If yes, I'm
going to merge for 5.7, otherwise for 5.8.
thanks,
Takashi
next prev parent reply other threads:[~2020-05-04 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 8:16 Sameer Pujar
2020-05-04 8:16 ` [PATCH 1/3] ALSA: hda/tegra: correct number of SDO lines for Tegra194 Sameer Pujar
2020-05-04 8:16 ` [PATCH 2/3] ALSA: hda: add member to store ratio for stripe control Sameer Pujar
2020-05-04 8:16 ` [PATCH 3/3] ALSA: hda/tegra: workaround playback failure on Tegra194 Sameer Pujar
2020-05-04 8:29 ` Takashi Iwai [this message]
2020-05-04 8:35 ` [PATCH 0/3] Tegra194 HW Fixes Sameer Pujar
2020-05-04 8:48 ` Sameer Pujar
2020-05-04 9:53 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ho8r4f6hx.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=rlokhande@nvidia.com \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®