mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda/realtek: Fix pop noise on ALC225
Date: Wed, 11 Mar 2020 07:54:12 +0100	[thread overview]
Message-ID: <s5ho8t39yaz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200311061328.17614-1-kai.heng.feng@canonical.com>

On Wed, 11 Mar 2020 07:13:28 +0100,
Kai-Heng Feng wrote:
> 
> Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to
> 0") makes the ALC225 have pop noise on S3 resume and cold boot.
> 
> So partially revert this commit for ALC225 to fix the regression.
> 
> Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0")
> BugLink: https://bugs.launchpad.net/bugs/1866357
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---

Hrm, it's rather surprising.  The power_save_node was thought to be a
cause of the pop noise, but in this case it fixes.  It's interesting
because this codec chip has no loopback mixer, and the connection is
directly from DAC to pin, so in theory, it shouldn't be influenced
from other nodes.

Anyways, a slight concern is that this might cause a regression on
another machine.  But who knows, maybe the influence is very limited.
Let's apply it and see what happens.


thanks,

Takashi

  reply	other threads:[~2020-03-11  6:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  6:13 Kai-Heng Feng
2020-03-11  6:54 ` Takashi Iwai [this message]
2020-03-11  8:54   ` Kai-Heng Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ho8t39yaz.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®