From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AED8C43381 for ; Mon, 18 Mar 2019 12:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B3EF20857 for ; Mon, 18 Mar 2019 12:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727600AbfCRMu7 (ORCPT ); Mon, 18 Mar 2019 08:50:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:35208 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726612AbfCRMu6 (ORCPT ); Mon, 18 Mar 2019 08:50:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6F667AC43; Mon, 18 Mar 2019 12:50:57 +0000 (UTC) Date: Mon, 18 Mar 2019 13:50:56 +0100 Message-ID: From: Takashi Iwai To: "Colin King" Cc: , "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration In-Reply-To: <20190317232124.7740-1-colin.king@canonical.com> References: <20190317232124.7740-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Mar 2019 00:21:24 +0100, Colin King wrote: > > From: Colin Ian King > > The function snd_opl3_drum_switch declaration in the header file > has the order of the two arguments on_off and vel swapped when > compared to the definition arguments of vel and on_off. Fix this > by swapping them around to match the definition. > > This error predates the git history, so no idea when this error > was introduced. > > Signed-off-by: Colin Ian King Thanks, applied. Takashi