From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ADA4C43441 for ; Fri, 9 Nov 2018 13:28:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE03020825 for ; Fri, 9 Nov 2018 13:28:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE03020825 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728031AbeKIXIw (ORCPT ); Fri, 9 Nov 2018 18:08:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:43794 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727793AbeKIXIw (ORCPT ); Fri, 9 Nov 2018 18:08:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AA304ADD4; Fri, 9 Nov 2018 13:28:12 +0000 (UTC) Date: Fri, 09 Nov 2018 14:28:12 +0100 Message-ID: From: Takashi Iwai To: Ayman Bagabas Cc: ALSA Development Mailing List , Hui Wang , Andy Shevchenko , Darren Hart , Jaroslav Kysela , Kailang Yang , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED In-Reply-To: References: <20181108171701.4444-1-ayman.bagabas@gmail.com> <20181108171701.4444-4-ayman.bagabas@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Nov 2018 14:20:47 +0100, Ayman Bagabas wrote: > > [1 ] > > On Fri, Nov 9, 2018, 4:01 AM Takashi Iwai > On Thu, 08 Nov 2018 18:16:55 +0100, > Ayman Bagabas wrote: > > > > diff --git a/drivers/platform/x86/huawei_wmi.c b/drivers/platform/x86/ > huawei_wmi.c > > index 658c44ab2126..f06aa967c311 100644 > > --- a/drivers/platform/x86/huawei_wmi.c > > +++ b/drivers/platform/x86/huawei_wmi.c > > @@ -23,6 +23,7 @@ > >  #include > >  #include > > >  #include > > +#include > >  > >  MODULE_AUTHOR("Ayman Bagabas "); > >  MODULE_DESCRIPTION("Huawei WMI hotkeys"); > > diff --git a/include/linux/platform_data/x86/huawei_wmi.h b/include/ > linux/platform_data/x86/huawei_wmi.h > > new file mode 100644 > > index 000000000000..dd251780ee5c > > --- /dev/null > > +++ b/include/linux/platform_data/x86/huawei_wmi.h > > @@ -0,0 +1,9 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) > > +#ifndef __HUAWEI_WMI_H__ > > +#define __HUAWEI_WMI_H__ > > + > > +int huawei_wmi_micmute_led_set(bool on); > > + > > +#endif > > +#endif > > These changes should belong to the WMI patch. > > > @@ -5765,6 +5769,10 @@ static const struct hda_fixup alc269_fixups[] = { > >               .chained = true, > >               .chain_id = ALC269_FIXUP_HEADSET_MIC > >       }, > > +     [ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED] = { > > +             .type = HDA_FIXUP_FUNC, > > +             .v.func = alc_fixup_huawei_wmi > > +     }, > >       [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { > >               .type = HDA_FIXUP_PINS, > >               .v.pins = (const struct hda_pintbl[]) { > > @@ -5779,7 +5787,9 @@ static const struct hda_fixup alc269_fixups[] = { > >                       {0x1e, 0x411111f0}, > >                       {0x21, 0x04211020}, > >                       { } > > -             } > > +             }, > > +             .chained = true, > > +             .chain_id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED > >       }, > >       [ALC269_FIXUP_ASUS_X101_FUNC] = { > >               .type = HDA_FIXUP_FUNC, > > This means that ALC256_FIXUP_HUAWEI_MBXP_PINS performs both the pin > config fixup and the mic-mute LED enablement. > > > @@ -6609,6 +6619,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl > [] = { > >       SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", > ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > >       SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", > ALC298_FIXUP_TPT470_DOCK), > >       SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", > ALC298_FIXUP_TPT470_DOCK), > > +     SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", > ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED), > >       SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", > ALC256_FIXUP_HUAWEI_MBXP_PINS), > >       SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), > >       SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", > ALC269_FIXUP_LENOVO_EAPD), > > ... and yet you add a new entry for performing only mic-mute LED. > I guess the chaining is done wrongly above? > > They are suppose to be two different devices. MBXP should apply both, but the > MBX should only perform the LED. Then please write it the changelog. Otherwise readers have no idea whether it's an intentional change or an oversight. thanks, Takashi