From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751501AbdIEHl7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Sep 2017 03:41:59 -0400
Received: from mx2.suse.de ([195.135.220.15]:37165 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751373AbdIEHlz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Sep 2017 03:41:55 -0400
Date: Tue, 05 Sep 2017 09:41:53 +0200
Message-ID: <s5ho9qptwvy.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Johannes Stezenbach <js@sig21.net>,
        platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC
In-Reply-To: <20170905072553.cffjdmlxamop4c5r@dell>
References: <20170824081141.5018-1-tiwai@suse.de>
        <20170824081141.5018-2-tiwai@suse.de>
        <20170904133732.ll6cmuvnxja242gi@dell>
        <s5h1snmr2rp.wl-tiwai@suse.de>
        <20170905072553.cffjdmlxamop4c5r@dell>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 05 Sep 2017 09:25:53 +0200,
Lee Jones wrote:
> 
> On Mon, 04 Sep 2017, Takashi Iwai wrote:
> 
> > On Mon, 04 Sep 2017 15:37:32 +0200,
> > Lee Jones wrote:
> > > 
> > > > +static struct mfd_cell dc_ti_dev[] = {
> > > > +	{
> > > > +		.name = "dc_ti_pwrbtn",
> > > > +		.num_resources = ARRAY_SIZE(power_button_resources),
> > > > +		.resources = power_button_resources,
> > > > +	},
> > > > +	{
> > > 
> > > Place these on the same line.
> > 
> > Does this and ...
> > 
> > 
> > > > +	},
> > > > +	{
> > > > +		.name = "dc_ti_region",
> > > > +	},
> > > 
> > > This should be a one line entry:
> > > 
> > > 	{ .name = "dc_ti_region" },
> > 
> > .... this match together?  The result would be like:
> > 
> > static struct mfd_cell dc_ti_dev[] = {
> > 	{
> > 		.name = "dc_ti_pwrbtn",
> > 		.num_resources = ARRAY_SIZE(power_button_resources),
> > 		.resources = power_button_resources,
> > 	}, {
> > 		.name = "chtdc_ti_adc",
> > 		.num_resources = ARRAY_SIZE(adc_resources),
> > 	.....
> > 	}, {	.name = "chtdc_ti_region",	},
> > };
> > 
> > which I find a bit inconsistent.
> 
> No, it doesn't.

Heh, I find such a mixture annoying, but it's a matter of taste.

> The single lines need to be on their own.

So did I already in the v5 patch submitted yesterday.


thanks,

Takashi