From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757594AbcH3HFx (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 03:05:53 -0400
Received: from mx2.suse.de ([195.135.220.15]:40415 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751975AbcH3HFw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 03:05:52 -0400
Date: Tue, 30 Aug 2016 09:05:50 +0200
Message-ID: <s5hoa4a3fe9.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: alsa-devel@alsa-project.org, Hui Wang <hui.wang@canonical.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559
In-Reply-To: <CAAd53p4stFs1GzGtbzRKVa6GVcotrFprsN_OO5ZA7jjQnf+3wg@mail.gmail.com>
References: <20160830052741.20190-1-kai.heng.feng@canonical.com>
        <s5h4m624y7s.wl-tiwai@suse.de>
        <CAAd53p4stFs1GzGtbzRKVa6GVcotrFprsN_OO5ZA7jjQnf+3wg@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 30 Aug 2016 08:25:18 +0200,
Kai Heng Feng wrote:
> 
> On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Tue, 30 Aug 2016 07:27:41 +0200,
> > Kai-Heng Feng wrote:
> >>
> >> The subwoofer on Inspiron 7559 does not work originally.
> >> Applying a pin fixup can make it work.
> >>
> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> ---
> >>  sound/pci/hda/patch_realtek.c | 11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >>
> >> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> >> index 7100f05..2a3dd18 100644
> >> --- a/sound/pci/hda/patch_realtek.c
> >> +++ b/sound/pci/hda/patch_realtek.c
> >> @@ -4855,6 +4855,7 @@ enum {
> >>       ALC221_FIXUP_HP_FRONT_MIC,
> >>       ALC292_FIXUP_TPT460,
> >>       ALC298_FIXUP_SPK_VOLUME,
> >> +     ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER,
> >>  };
> >>
> >>  static const struct hda_fixup alc269_fixups[] = {
> >> @@ -5516,6 +5517,15 @@ static const struct hda_fixup alc269_fixups[] = {
> >>               .chained = true,
> >>               .chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
> >>       },
> >> +     [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
> >> +             .type = HDA_FIXUP_PINS,
> >> +             .v.pins = (const struct hda_pintbl[]) {
> >> +                     { 0x1b, 0x90170151 },
> >
> > What's the original value of this pin?
> >
> >
> > Takashi
> 
> The original value of 0x1b is 0x411111f0.

OK, so it was disabled.  Maybe better to mention it in the patch
description.


Takashi