From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751307AbcBMIlO (ORCPT ); Sat, 13 Feb 2016 03:41:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:50898 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbcBMIlM (ORCPT ); Sat, 13 Feb 2016 03:41:12 -0500 Date: Sat, 13 Feb 2016 09:41:11 +0100 Message-ID: From: Takashi Iwai To: "Andrey Konovalov" Cc: , "Clemens Ladisch" , "Jaroslav Kysela" , , , , Subject: Re: [PATCH] midi: avoid freeing umidi object twice In-Reply-To: <1455350886-21126-1-git-send-email-andreyknvl@gmail.com> References: <1455350886-21126-1-git-send-email-andreyknvl@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Feb 2016 09:08:06 +0100, Andrey Konovalov wrote: > > The 'umidi' object will be free'd on the error path by snd_usbmidi_free() > when tearing down the rawmidi interface. So we shouldn't try to free it > in snd_usbmidi_create() after having registered the rawmidi interface. > > Found by KASAN. > > Acked-by: Clemens Ladisch > Signed-off-by: Andrey Konovalov Thanks, applied now with Cc to stable. Takashi > --- > sound/usb/midi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/usb/midi.c b/sound/usb/midi.c > index cc39f63..007cf58 100644 > --- a/sound/usb/midi.c > +++ b/sound/usb/midi.c > @@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card, > else > err = snd_usbmidi_create_endpoints(umidi, endpoints); > if (err < 0) { > - snd_usbmidi_free(umidi); > return err; > } > > -- > 1.9.1 > >