From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752432AbaKCPTB (ORCPT ); Mon, 3 Nov 2014 10:19:01 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53845 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbaKCPTA (ORCPT ); Mon, 3 Nov 2014 10:19:00 -0500 Date: Mon, 03 Nov 2014 16:18:58 +0100 Message-ID: From: Takashi Iwai To: Joe Perches Cc: Sudip Mukherjee , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ALSA: echoaudio: add reference of struct echoaudio In-Reply-To: <1415027288.17743.16.camel@perches.com> References: <1415010853-4334-1-git-send-email-sudipm.mukherjee@gmail.com> <1415027288.17743.16.camel@perches.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 03 Nov 2014 07:08:08 -0800, Joe Perches wrote: > > On Mon, 2014-11-03 at 15:17 +0100, Takashi Iwai wrote: > > At Mon, 3 Nov 2014 16:04:12 +0530, > > Sudip Mukherjee wrote: > > > > > > added reference of struct echoaudio to free_firmware function. > > > this structure will be later used to get a reference of the card > > > when converting snd_printk to dev_* in the next patch of the series. > > > > > > Signed-off-by: Sudip Mukherjee > > > > Thanks, now applied both. Though, I noticed that there is also a > > dev_notice() usage that should be also dev_dbg(). Corrected such > > lines in my side. > > Are any of these changes going to cause a > null pointer dereference of chip->card->dev? All look OK at a quick glance. There was a recent change to make card->dev mandatory, so it's there from the very beginning. > ftrace exists and is generic. > > Several of these seem to be function tracing > style uses and should just be deleted instead. True. Further cleanup patches appreciated. thanks, Takashi