From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759543Ab2FHHIm (ORCPT ); Fri, 8 Jun 2012 03:08:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53940 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753269Ab2FHHIk (ORCPT ); Fri, 8 Jun 2012 03:08:40 -0400 Date: Fri, 08 Jun 2012 09:08:35 +0200 Message-ID: From: Takashi Iwai To: Jamie Heilman Cc: Daniel Mack , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: 3.5-rc1 snd_usb_audio stream format breakage In-Reply-To: <20120607081735.GA4648@cucamonga.audible.transient.net> References: <20120607033830.GB4321@cucamonga.audible.transient.net> <20120607081735.GA4648@cucamonga.audible.transient.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 7 Jun 2012 08:17:35 +0000, Jamie Heilman wrote: > > Takashi Iwai wrote: > > At Thu, 7 Jun 2012 03:38:30 +0000, > > Jamie Heilman wrote: > > > > > > With the USB audio streaming logic changes, my HeadRoom Bithead > > > (08bb:2902 Burr-Brown PCM2902) no longer works. Symptoms include the > > > loss of most of the normally available formats leaving only: > > > > > > root@cucamonga:~# cat /proc/asound/bithead/stream0 > > > Burr-Brown from TI USB Audio CODEC at usb-0000:00:1a.7-1.1.4, full speed : USB Audio > > > > > > Playback: > > > Status: Stop > > > Interface 1 > > > Altset 6 > > > Format: U8 > > > Channels: 1 > > > Endpoint: 2 OUT (ADAPTIVE) > > > Rates: 32000, 44100, 48000 > > > > > > Capture: > > > Status: Stop > > > Interface 2 > > > Altset 18 > > > Format: S8 > > > Channels: 1 > > > Endpoint: 4 IN (SYNC) > > > Rates: 11025 > > > > > > (normally 2 channel S16_LE is available, with capture rates up to > > > 48kHz ... only the last altset's are being reported now) and a slew of > > > proc registration warnings logged: > > > > > > ------------[ cut here ]------------ > > > WARNING: at fs/proc/generic.c:586 proc_register+0x169/0x1a6() > > > Hardware name: Precision WorkStation T3400 > > > proc_dir_entry 'card1/pcm0p' already registered > > > Modules linked in: snd_usb_audio(+) snd_usbmidi_lib snd_hda_intel(+) snd_hda_codec snd_hwdep snd_seq_midi snd_seq_midi_event snd_pcm snd_page_alloc snd_rawmidi snd_seq snd_seq_device snd_timer snd soundcore dcdbas floppy sr_mod usb_storage cdrom kvm_intel psmouse kvm tg3 evdev xfs dm_mod raid1 md_mod > > > Pid: 1152, comm: modprobe Not tainted 3.5.0-rc1-00110-g71fae7e #2 > > > Call Trace: > > > [] warn_slowpath_common+0x83/0x9c > > > [] warn_slowpath_fmt+0x46/0x48 > > > [] ? add_preempt_count+0x39/0x3b > > > [] proc_register+0x169/0x1a6 > > > [] create_proc_entry+0x74/0x8c > > > [] snd_info_register+0x3e/0xc3 [snd] > > > [] snd_pcm_new_stream+0xb1/0x404 [snd_pcm] > > > [] snd_usb_add_audio_stream+0xd2/0x230 [snd_usb_audio] > > > [] ? snd_usb_parse_audio_format+0x252/0x34f [snd_usb_audio] > > > [] ? kmem_cache_alloc_trace+0xab/0xbb > > > [] snd_usb_parse_audio_interface+0x4ac/0x567 [snd_usb_audio] > > > [] snd_usb_create_stream+0xe9/0x125 [snd_usb_audio] > > > [] usb_audio_probe+0x62a/0x72c [snd_usb_audio] > > > [] usb_probe_interface+0x136/0x1b1 > > > [] ? driver_probe_device+0x1d3/0x1d3 > > > [] driver_probe_device+0xb0/0x1d3 > > > [] __driver_attach+0x5f/0x83 > > > [] bus_for_each_dev+0x54/0x86 > > > [] driver_attach+0x1e/0x20 > > > [] bus_add_driver+0xfd/0x23a > > > [] driver_register+0x93/0x10e > > > [] usb_register_driver+0x7e/0x12a > > > [] ? 0xffffffffa0256fff > > > [] ? 0xffffffffa0256fff > > > [] snd_usb_audio_init+0x40/0x1000 [snd_usb_audio] > > > [] do_one_initcall+0x7f/0x134 > > > [] ? 0xffffffffa0256fff > > > [] sys_init_module+0x16cf/0x195e > > > [] ? free_notes_attrs+0x4d/0x4d > > > [] ? mmap_region+0x1c7/0x469 > > > [] system_call_fastpath+0x16/0x1b > > > ---[ end trace c1baea1a25a91564 ]--- > > > > Looks like the PCM substream assignment is buggy. > > Does the patch (untested at all) below help? > > Yep, that fixed it. Thanks! OK, applied the fix now. Thanks for quick testing. Takashi