From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757275Ab0G2MCQ (ORCPT ); Thu, 29 Jul 2010 08:02:16 -0400 Received: from cantor.suse.de ([195.135.220.2]:42134 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756996Ab0G2MCP (ORCPT ); Thu, 29 Jul 2010 08:02:15 -0400 Date: Thu, 29 Jul 2010 14:02:13 +0200 Message-ID: From: Takashi Iwai To: Kulikov Vasiliy Cc: kernel-janitors@vger.kernel.org, Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10 v2] ALSA: msnd: check request_region() return value In-Reply-To: <1280400325-9405-1-git-send-email-segooon@gmail.com> References: <1280400325-9405-1-git-send-email-segooon@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 29 Jul 2010 14:45:24 +0400, Kulikov Vasiliy wrote: > > request_region() may fail, if so return -EBUSY. > > Signed-off-by: Kulikov Vasiliy Thanks, applied both patches now. Takashi > --- > sound/isa/msnd/msnd_pinnacle.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/sound/isa/msnd/msnd_pinnacle.c b/sound/isa/msnd/msnd_pinnacle.c > index 60b6abd..ed42f8e 100644 > --- a/sound/isa/msnd/msnd_pinnacle.c > +++ b/sound/isa/msnd/msnd_pinnacle.c > @@ -549,7 +549,10 @@ static int __devinit snd_msnd_attach(struct snd_card *card) > printk(KERN_ERR LOGNAME ": Couldn't grab IRQ %d\n", chip->irq); > return err; > } > - request_region(chip->io, DSP_NUMIO, card->shortname); > + if (request_region(chip->io, DSP_NUMIO, card->shortname) == NULL) { > + free_irq(chip->irq, chip); > + return -EBUSY; > + } > > if (!request_mem_region(chip->base, BUFFSIZE, card->shortname)) { > printk(KERN_ERR LOGNAME > -- > 1.7.0.4 >