From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754087Ab0DSK3v (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Apr 2010 06:29:51 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43678 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752818Ab0DSK3u (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Apr 2010 06:29:50 -0400
Date: Mon, 19 Apr 2010 12:29:49 +0200
Message-ID: <s5hochfpwf6.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] input: Add support of Synaptics Clickpad device
In-Reply-To: <20100419083221.GB26102@core.coreip.homeip.net>
References: <1271257823-23566-1-git-send-email-tiwai@suse.de>
	<1271257823-23566-2-git-send-email-tiwai@suse.de>
	<20100419083221.GB26102@core.coreip.homeip.net>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dmitry,

At Mon, 19 Apr 2010 01:32:22 -0700,
Dmitry Torokhov wrote:
> 
> Hi Takashi,
> 
> On Wed, Apr 14, 2010 at 05:10:22PM +0200, Takashi Iwai wrote:
> > Add the detection of Synaptics Clickpad device.
> > The device can be detected a new query command 0x0c.  The clickpad
> > flags are in cap[0]:4 and cap[1]:0 bits.  But, the driver checks
> > first the product id bits in the ext capabilities to be sure, so
> > that it skips the new check on older devices.
> > 
> 
> Instead of looking at the product id, can we check the number of
> supported extended capabilities queries and act accordingly, like the
> patch below?

Yes, it worked.  (Though, I've tested only new machines.)


> @@ -162,6 +163,16 @@ static int synaptics_capability(struct psmouse *psmouse)
>  				priv->ext_cap &= 0xff0fff;
>  		}
>  	}
> +
> +	if (SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 4) {
> +		if (synaptics_send_cmd(psmouse, SYN_QUE_EXT_CAPAB_0C, cap)) {
> +			printk(KERN_ERR "Synaptics claims to have extended capability 0x0c,"
> +			       " but I'm not able to read it.");

Here missing a newline, BTW.


thanks,

Takashi