From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753714AbZKLREx (ORCPT ); Thu, 12 Nov 2009 12:04:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753667AbZKLREw (ORCPT ); Thu, 12 Nov 2009 12:04:52 -0500 Received: from cantor.suse.de ([195.135.220.2]:35531 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670AbZKLREs (ORCPT ); Thu, 12 Nov 2009 12:04:48 -0500 Date: Thu, 12 Nov 2009 18:04:53 +0100 Message-ID: From: Takashi Iwai To: Roel Kluin Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, Andrew Morton , LKML Subject: Re: [PATCH] OSS: fix error return in dma_ioctl() In-Reply-To: <4AFC3B1F.1050901@gmail.com> References: <4AFC3B1F.1050901@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 12 Nov 2009 17:43:11 +0100, Roel Kluin wrote: > > The returned error should stay negative > > Signed-off-by: Roel Kluin > --- > sound/oss/audio.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/oss/audio.c b/sound/oss/audio.c > index b69c05b..7df48a2 100644 > --- a/sound/oss/audio.c > +++ b/sound/oss/audio.c > @@ -838,7 +838,7 @@ static int dma_ioctl(int dev, unsigned int cmd, void __user *arg) > if ((err = audio_devs[dev]->d->prepare_for_input(dev, > dmap_in->fragment_size, dmap_in->nbufs)) < 0) { > spin_unlock_irqrestore(&dmap_in->lock,flags); > - return -err; > + return err; Hmm, looks like a wrong fix to me. Here, err itself is already negative, so you don't need to flip the sign. thanks, Takashi