mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 19/19] sound: Use PCI_VDEVICE
Date: Thu, 25 Jun 2009 07:43:16 +0200	[thread overview]
Message-ID: <s5hocscna17.wl%tiwai@suse.de> (raw)
In-Reply-To: <e27f875baa15d3d3e34c2a005cea9d702e822c57.1245906153.git.joe@perches.com>

At Wed, 24 Jun 2009 22:13:35 -0700,
Joe Perches wrote:
> diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c
> index 18f4d1e..d589bbc 100644
> --- a/sound/pci/ens1370.c
> +++ b/sound/pci/ens1370.c
> @@ -445,11 +445,11 @@ static irqreturn_t snd_audiopci_interrupt(int irq, void *dev_id);
>  
>  static struct pci_device_id snd_audiopci_ids[] = {
>  #ifdef CHIP1370
> -	{ 0x1274, 0x5000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },	/* ES1370 */
> +	{ PCI_VDEVICE(ENSONIQ, 0x5000), 0, },	/* ES1370 */
>  #endif
>  #ifdef CHIP1371
> -	{ 0x1274, 0x1371, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },	/* ES1371 */
> -	{ 0x1274, 0x5880, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },	/* ES1373 - CT5880 */
> +	{ PCI_VDEVICE(ENSONIQ, 0x1371), 0, },	/* ES1371 */
> +	{ PCI_VDEVICE(ENSONIQ, 0x5880), 0, },	/* ES1373 - CT5880 */
>  	{ 0x1102, 0x8938, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },	/* Ectiva EV1938 */

Any reason not to covert this?


thanks,

Takashi

  reply	other threads:[~2009-06-25  5:43 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25  5:13 [PATCH 00/19] " Joe Perches
2009-06-25  5:13 ` [PATCH 01/19] drivers/ata: " Joe Perches
2009-06-25  5:13 ` [PATCH 02/19] drivers/atm: " Joe Perches
2009-06-25  5:13 ` [PATCH 03/19] drivers/block: " Joe Perches
2009-06-25  5:13 ` [PATCH 04/19] drivers/char/hw_random: " Joe Perches
2009-06-25  5:36   ` Matt Mackall
2009-06-25  5:51     ` Herbert Xu
2009-06-25  5:13 ` [PATCH 05/19] drivers/isdn: " Joe Perches
2009-06-25  5:13 ` [PATCH 06/19] drivers/media: " Joe Perches
2009-06-25  5:13 ` [PATCH 07/19] drivers/memstick: " Joe Perches
2009-06-25  5:13 ` [PATCH 08/19] drivers/misc: " Joe Perches
2009-06-25  5:13 ` [PATCH 09/19] drivers/mmc: " Joe Perches
2009-06-25  5:13 ` [PATCH 10/19] drivers/net/wan: " Joe Perches
2009-06-28 11:43   ` Krzysztof Halasa
2009-06-25  5:13 ` [PATCH 11/19] drivers/net/wireless: " Joe Perches
2009-06-25 20:30   ` reinette chatre
2009-06-25  5:13 ` [PATCH 12/19] drivers/net: " Joe Perches
2009-06-25  5:50   ` David Dillow
2009-06-25  6:19   ` Grant Grundler
2009-06-25 12:24   ` Daniele Venzano
2009-06-25 13:52   ` Jens Osterkamp
2009-06-25  5:13 ` [PATCH 13/19] drivers/parport: " Joe Perches
2009-06-25  5:13 ` [PATCH 14/19] drivers/scsi: " Joe Perches
2009-06-27 17:20   ` James Bottomley
2009-06-27 19:53     ` Joe Perches
2009-06-27 20:56       ` James Bottomley
2009-06-28  1:25         ` Joe Perches
2009-06-25  5:13 ` [PATCH 15/19] drivers/serial: " Joe Perches
2009-06-25  5:13 ` [PATCH 16/19] drivers/staging: " Joe Perches
2009-06-25 14:24   ` Jiri Slaby
2009-06-25 14:53     ` Joe Perches
2009-07-02 20:06       ` Greg KH
2009-06-25  5:13 ` [PATCH 17/19] drivers/telephony: " Joe Perches
2009-06-25  5:13 ` [PATCH 18/19] drivers/video: " Joe Perches
2009-06-26  9:54   ` Ville Syrjälä
2009-06-26 16:35     ` Joe Perches
2009-06-26 17:31       ` Ville Syrjälä
2009-06-25  5:13 ` [PATCH 19/19] sound: " Joe Perches
2009-06-25  5:43   ` Takashi Iwai [this message]
2009-06-25  5:47     ` Joe Perches
2009-06-25  5:55       ` Takashi Iwai
2009-06-25  6:18         ` [PATCH 20/19] sound: Use PCI_VDEVICE for CREATIVE and ECTIVA Joe Perches
2009-06-25  6:59           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hocscna17.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®