From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762243AbYENNBg (ORCPT ); Wed, 14 May 2008 09:01:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758465AbYENNB2 (ORCPT ); Wed, 14 May 2008 09:01:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:46515 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756340AbYENNB1 (ORCPT ); Wed, 14 May 2008 09:01:27 -0400 Date: Wed, 14 May 2008 15:01:23 +0200 Message-ID: From: Takashi Iwai To: Rene Herman Cc: Bjorn Helgaas , Alan Cox , Glauber Costa , Ingo Molnar , Thomas Gleixner , Pete Clements , Linux Kernel , ALSA devel Subject: Re: 2.6.26-rc1 regression: ISA DMA broken (bisected) In-Reply-To: <482ADF34.2010004@keyaccess.nl> References: <4823AAF2.7070102@keyaccess.nl> <20080513180107.1a3893f1@core> <4829D0E5.8050905@keyaccess.nl> <200805131718.40138.bjorn.helgaas@hp.com> <482ADF34.2010004@keyaccess.nl> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 14 May 2008 14:46:44 +0200, Rene Herman wrote: > > On 14-05-08 01:18, Bjorn Helgaas wrote: > > > On Tuesday 13 May 2008 11:33:25 am Rene Herman wrote: > > >> No, isa_device is its own thing, on its own isa_bus (*). It has a struct > >> device * readily available though... > >> > >> (*) drivers/base/isa.c, and explanatory changelog at: > >> > >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a5117ba7da37deb09df5eb802dace229b3fb1e9f > > > > Thanks for the nice changelog. > > > > isa_register_driver() currently doesn't set a DMA mask. Should it? > > If it's going to be useful, definitely. The attached does not just set > > dev->dma_mask = &dev->coherent_dma_mask > > as in the fallback_dev when dma_alloc_coherent() is passed a NULL device > only due to the mask juggling in snd_dma_hack_alloc_coherent() (which > wouldn't break, but...) but introduces its own copy in struct isa_dev > same as struct pnp_dev. As far as I'm aware, there's no actual reason > for keeping it other than that and if the hack could go I'd rather lose > the private mask copy again also. The snd_dma_hack_alloc_coherent() is gone in the latest ALSA tree. It wasn't merged to 2.6.26, though. > (the device model still uses a plain u64 by the way but I guess the > clean type would be a dma64_addr_t) > > Inlining is whitespace-failing here. Patch itself is trivial... > > > I only see about 35 dma_alloc_coherent() calls that pass NULL. I > > guess even those would be a fair amount of work to change, and I > > suppose there would be more that I missed. > > At least the ALSA one isn't passing a literal NULL it seems. But yes, > current NULL-hack reinstatement (it's been merged by Linus already) is > definitely the correct fix for now. Yes. We need to fix the caller of snd_pcm_lib_preallocate_pages*() under sound/isa. Currently it's called with snd_dma_isa_data(), which is expanded to NULL. Replace it with a proper device pointer should suffice. Takashi