From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751105AbWDJJzZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751105AbWDJJzZ (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 10 Apr 2006 05:55:25 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751107AbWDJJzZ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 10 Apr 2006 05:55:25 -0400
Received: from ns1.suse.de ([195.135.220.2]:15836 "EHLO mx1.suse.de")
	by vger.kernel.org with ESMTP id S1751105AbWDJJzY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 10 Apr 2006 05:55:24 -0400
Date: Mon, 10 Apr 2006 11:55:22 +0200
Message-ID: <s5hodz992lx.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Adrian Bunk <bunk@stusta.de>, perex@suse.cz, alsa-devel@alsa-project.org,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] move EXPORT_SYMBOL's away from sound/pci/emu10k1/emu10k1_main.c
In-Reply-To: <20060407184909.GB9097@mars.ravnborg.org>
References: <20060407003105.GG7118@stusta.de>
	<s5hu095y367.wl%tiwai@suse.de>
	<20060407184909.GB9097@mars.ravnborg.org>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25)
 (eggplant) (+CVS-20060326) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 7 Apr 2006 20:49:09 +0200,
Sam Ravnborg wrote:
> 
> On Fri, Apr 07, 2006 at 02:34:56PM +0200, Takashi Iwai wrote:
> > At Fri, 7 Apr 2006 02:31:05 +0200,
> > Adrian Bunk wrote:
> > > 
> > > This patch moves the EXPORT_SYMBOL's from 
> > > sound/pci/emu10k1/emu10k1_main.c to the files with the actual functions.
> > 
> > What is the merit of this movement?
> 
> 1) Documentation - it is obvious that the function/data is exported so
> be a bit mroe careful when introducing changes
> 2) Style. In 2.6 the preferred style is to put the EXPORT_SYMBOL on the
> line following the closing } of the exported function.
> 3) Keep changes local. If one removes a previously exported symbol less
> files needs to be touched.

I know the above for the new codes, yes.  But my question is wheter do
we get a good enough benifit by changing the existing code.

I'm not against such an action but just wornder whether it's really
needed.  If yes, we should do it over the whole tree.


Takashi