From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB324C433F5 for ; Wed, 10 Nov 2021 14:33:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 884ED611AD for ; Wed, 10 Nov 2021 14:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232193AbhKJOf7 (ORCPT ); Wed, 10 Nov 2021 09:35:59 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:53070 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231731AbhKJOf5 (ORCPT ); Wed, 10 Nov 2021 09:35:57 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B755B1FD63; Wed, 10 Nov 2021 14:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1636554788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a7/tXrG1LGQXohNn+eUyg7B/bjycMfboDc+vZ1jI5Rg=; b=FicL/c0kr+EzHMBL2Bq61fxVheD25oMosP70CyIlNBw6uEBMdJFj2umuTeIaxGe/HFeGFn iS82Ab3uYeItt5+s1nRqVaNCThYrcLvU2U1hkHeQpf0OpZGDqgOaDWmfQyqKrJTIS2/b+J NxwFi6vs+1PvZXUR1n+WuTar93jLWCg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1636554788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a7/tXrG1LGQXohNn+eUyg7B/bjycMfboDc+vZ1jI5Rg=; b=jfDZfPEG1xsC2RkB/VfJWkpybybGB1qT8pOSUjs7PD4PsZ5G9logf5i2t6Raq20w6/2U7Y sR5IkRyFzIWklTBg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 2141DA3B84; Wed, 10 Nov 2021 14:33:04 +0000 (UTC) Date: Wed, 10 Nov 2021 15:33:08 +0100 Message-ID: From: Takashi Iwai To: Scott Branden Cc: perex@perex.cz, tiwai@suse.com, ranjani.sridharan@linux.intel.com, broonie@kernel.org, kai.vehmanen@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, regressions@leemhuis.info Subject: Re: 5.15 Linux Regression in sound hda In-Reply-To: <063e2397-7edb-5f48-7b0d-618b938d9dd8@broadcom.com> References: <063e2397-7edb-5f48-7b0d-618b938d9dd8@broadcom.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Nov 2021 22:12:30 +0100, Scott Branden wrote: > > I'm reporting a new WARN_ON in sound/hda/hdac_bus.c that was not > present in 5.15. Sorry, I don't have time to bisect this right now > but report is below. > > dmesg in 5.14 kernel was: > snd_hda_intel 0000:00:1f.3: bound 0000:00:02.0 (ops 0xffffffffaa2ac520) > GACT probability on > Mirror/redirect action on > Simple TC action Loaded > u32 classifier > Performance counters on > input device check on > Actions configured > hdaudio hdaudioC0D0: Unable to bind the codec > hdaudio hdaudioC0D2: Unable to bind the codec > > dmesg in 5.15 kernel produces WARN_ON in sound/hda/hdac_bus.c > snd_hda_intel 0000:00:1f.3: bound 0000:00:02.0 (ops 0xffffffffad8b02a0) > GACT probability on > Mirror/redirect action on > Simple TC action Loaded > u32 classifier > Performance counters on > input device check on > Actions configured > snd_hda_intel 0000:00:1f.3: Cannot probe codecs, giving up > Initializing XFRM netlink socket > ------------[ cut here ]------------ > NET: Registered PF_INET6 protocol family > WARNING: CPU: 14 PID: 186 at sound/hda/hdac_bus.c:73 This indicates the leftover codecs on the bus, and it's likely triggered by the recent change to allow retrying the codec probes. Did this HD-audio stuff work at all before 5.15? The codec bind error itself shouldn't be brought by that change. The warning itself can be solved by the patch below, I suppose (note: totally untested!) thanks, Takashi --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2327,7 +2327,8 @@ static int azx_probe_continue(struct azx *chip) out_free: if (err < 0) { - azx_free(chip); + pci_set_drvdata(pci, NULL); + snd_card_free(chip->card); return err; }