From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7F4C433ED for ; Tue, 27 Apr 2021 10:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0588D613BE for ; Tue, 27 Apr 2021 10:55:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235757AbhD0Kzs (ORCPT ); Tue, 27 Apr 2021 06:55:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:46480 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230341AbhD0Kzq (ORCPT ); Tue, 27 Apr 2021 06:55:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 72BB7B019; Tue, 27 Apr 2021 10:55:02 +0000 (UTC) Date: Tue, 27 Apr 2021 12:55:02 +0200 Message-ID: From: Takashi Iwai To: Shengjiu Wang Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, broonie@kernel.org Subject: Re: [PATCH 1/2] ALSA: pcm: Add support for 705.6KHz and 768KHz sample rate In-Reply-To: <1619519663-10406-1-git-send-email-shengjiu.wang@nxp.com> References: <1619519663-10406-1-git-send-email-shengjiu.wang@nxp.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Apr 2021 12:34:22 +0200, Shengjiu Wang wrote: > > Some high resolution codecs support 705.6KHz and 768KHz rates. > So extend supported sample rate to 768kHz in pcm.h. > > Signed-off-by: Shengjiu Wang How many devices require it for now? I don't want to extend the core definitions blindly unless those rates are really commonly used. You can add those specific rates in the codec driver instead. thanks, Takashi > --- > include/sound/pcm.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/sound/pcm.h b/include/sound/pcm.h > index 2e1200d17d0c..88056824ffec 100644 > --- a/include/sound/pcm.h > +++ b/include/sound/pcm.h > @@ -121,6 +121,8 @@ struct snd_pcm_ops { > #define SNDRV_PCM_RATE_192000 (1<<12) /* 192000Hz */ > #define SNDRV_PCM_RATE_352800 (1<<13) /* 352800Hz */ > #define SNDRV_PCM_RATE_384000 (1<<14) /* 384000Hz */ > +#define SNDRV_PCM_RATE_705600 (1<<15) /* 705600Hz */ > +#define SNDRV_PCM_RATE_768000 (1<<16) /* 768000Hz */ > > #define SNDRV_PCM_RATE_CONTINUOUS (1<<30) /* continuous range */ > #define SNDRV_PCM_RATE_KNOT (1<<31) /* supports more non-continuos rates */ > @@ -136,6 +138,9 @@ struct snd_pcm_ops { > #define SNDRV_PCM_RATE_8000_384000 (SNDRV_PCM_RATE_8000_192000|\ > SNDRV_PCM_RATE_352800|\ > SNDRV_PCM_RATE_384000) > +#define SNDRV_PCM_RATE_8000_768000 (SNDRV_PCM_RATE_8000_768000|\ > + SNDRV_PCM_RATE_705600|\ > + SNDRV_PCM_RATE_768000) > #define _SNDRV_PCM_FMTBIT(fmt) (1ULL << (__force int)SNDRV_PCM_FORMAT_##fmt) > #define SNDRV_PCM_FMTBIT_S8 _SNDRV_PCM_FMTBIT(S8) > #define SNDRV_PCM_FMTBIT_U8 _SNDRV_PCM_FMTBIT(U8) > -- > 2.27.0 >