From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B0BC433E0 for ; Fri, 7 Aug 2020 08:11:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3ADD22C9F for ; Fri, 7 Aug 2020 08:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbgHGILF (ORCPT ); Fri, 7 Aug 2020 04:11:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:47596 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgHGILE (ORCPT ); Fri, 7 Aug 2020 04:11:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2256FACA7; Fri, 7 Aug 2020 08:11:21 +0000 (UTC) Date: Fri, 07 Aug 2020 10:11:02 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: tiwai@suse.com, Jaroslav Kysela , Kailang Yang , Jian-Hong Pan , Hui Wang , Huacai Chen , Thomas Hebb , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] ALSA: hda/realtek: Fix pin default on Intel NUC 8 Rugged In-Reply-To: <20200807080514.15293-1-kai.heng.feng@canonical.com> References: <20200807080514.15293-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 07 Aug 2020 10:05:12 +0200, Kai-Heng Feng wrote: > > The jack on Intel NUC 8 Rugged rear panel doesn't work. > > The spec [1] states that the jack supports both headphone and > microphone, so override a Pin Complex which has both Amp-In and Amp-Out > to make the jack work. > > Node 0x1b fits the requirement, and user confirmed the jack now works > with new pin config. > > [1] https://www.intel.com/content/dam/support/us/en/documents/mini-pcs/NUC8CCH_TechProdSpec.pdf > BugLink: https://bugs.launchpad.net/bugs/1875199 > > Signed-off-by: Kai-Heng Feng OK, usually a codec quirk entry with 8086:* is doubtful, but in this case, it's really the Intel (reference) hardware, hence it should be so. Applied now. Thanks. Takashi > --- > sound/pci/hda/patch_realtek.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 2477f3ed7237..daedcc0adc21 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6159,6 +6159,7 @@ enum { > ALC269_FIXUP_CZC_L101, > ALC269_FIXUP_LEMOTE_A1802, > ALC269_FIXUP_LEMOTE_A190X, > + ALC256_FIXUP_INTEL_NUC8_RUGGED, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -7480,6 +7481,15 @@ static const struct hda_fixup alc269_fixups[] = { > }, > .chain_id = ALC269_FIXUP_DMIC, > }, > + [ALC256_FIXUP_INTEL_NUC8_RUGGED] = { > + .type = HDA_FIXUP_PINS, > + .v.pins = (const struct hda_pintbl[]) { > + { 0x1b, 0x01a1913c }, /* use as headset mic, without its own jack detect */ > + { } > + }, > + .chained = true, > + .chain_id = ALC269_FIXUP_HEADSET_MODE > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -7777,6 +7787,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x10ec, 0x118c, "Medion EE4254 MD62100", ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE), > SND_PCI_QUIRK(0x1c06, 0x2013, "Lemote A1802", ALC269_FIXUP_LEMOTE_A1802), > SND_PCI_QUIRK(0x1c06, 0x2015, "Lemote A190X", ALC269_FIXUP_LEMOTE_A190X), > + SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED), > > #if 0 > /* Below is a quirk table taken from the old code. > -- > 2.17.1 >