From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94361C3A5A9 for ; Sat, 2 May 2020 10:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71D32208DB for ; Sat, 2 May 2020 10:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbgEBKJQ (ORCPT ); Sat, 2 May 2020 06:09:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:45670 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbgEBKJQ (ORCPT ); Sat, 2 May 2020 06:09:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A957AAED6; Sat, 2 May 2020 10:09:14 +0000 (UTC) Date: Sat, 02 May 2020 12:09:13 +0200 Message-ID: From: Takashi Iwai To: Nicholas Johnson Cc: Lukas Wunner , Alex Deucher , "Zhou, David(ChunMing)" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Takashi Iwai , "Deucher, Alexander" , "Koenig, Christian" Subject: Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state In-Reply-To: References: <20200502071728.fn2fcqvt6aies3zu@wunner.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 02 May 2020 09:27:31 +0200, Takashi Iwai wrote: > > On Sat, 02 May 2020 09:17:28 +0200, > Lukas Wunner wrote: > > > > On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > @@ -673,6 +673,12 @@ static int amdgpu_dm_audio_component_bind(struct device *kdev, > > > struct amdgpu_device *adev = dev->dev_private; > > > struct drm_audio_component *acomp = data; > > > > > > + if (!device_link_add(hda_kdev, kdev, DL_FLAG_STATELESS | > > > + DL_FLAG_PM_RUNTIME)) { > > > + DRM_ERROR("DM: cannot add device link to audio device\n"); > > > + return -ENOMEM; > > > + } > > > + > > > > Doesn't this duplicate drivers/pci/quirks.c:quirk_gpu_hda() ? > > Gah, you're right, that was the place I overlooked. > It was a typical "false Eureka right-after-wakeup" phenomenon :) > Need a vaccine aka coffee... > > So the runtime PM dependency must be already placed there, and the > problem is not the lack of the dependency tree but the really other > timing issue. Back to square. One interesting test is to open the stream while the mode isn't set yet and see whether the same problem appears. Namely, after the monitor is connected but no mode is set, run directly like aplay -Dhdmi:1,0 foo.wav You might need to wrap the command with pasuspender if PA is active. Takashi