From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6273C3A5A6 for ; Mon, 23 Sep 2019 13:40:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD22E214DA for ; Mon, 23 Sep 2019 13:40:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730884AbfIWNks (ORCPT ); Mon, 23 Sep 2019 09:40:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:50958 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725854AbfIWNkr (ORCPT ); Mon, 23 Sep 2019 09:40:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 062E4B6AD; Mon, 23 Sep 2019 13:40:46 +0000 (UTC) Date: Mon, 23 Sep 2019 15:40:45 +0200 Message-ID: From: Takashi Iwai To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.2 072/185] ALSA: hda: Add codec on bus address table lately In-Reply-To: <20190923133025.GE8171@sasha-vm> References: <20190922184924.32534-1-sashal@kernel.org> <20190922184924.32534-72-sashal@kernel.org> <20190923133025.GE8171@sasha-vm> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Sep 2019 15:30:25 +0200, Sasha Levin wrote: > > On Sun, Sep 22, 2019 at 09:06:12PM +0200, Takashi Iwai wrote: > >On Sun, 22 Sep 2019 20:47:30 +0200, > >Sasha Levin wrote: > >> > >> From: Takashi Iwai > >> > >> [ Upstream commit ee5f85d9290fe25d460bd320b7fe073075d72d33 ] > >> > >> The call of snd_hdac_bus_add_device() is needed only for registering > >> the codec onto the bus caddr_tbl[] that is referred essentially only > >> in the unsol event handler. That is, the reason of this call and the > >> release by the counter-part function snd_hdac_bus_remove_device() is > >> just to assure that the unsol event gets notified to the codec. > >> > >> But the current implementation of the unsol notification wouldn't work > >> properly when the codec is still in a premature init state. So this > >> patch tries to work around it by delaying the caddr_tbl[] registration > >> at the point of snd_hdac_device_register(). > >> > >> Also, the order of snd_hdac_bus_remove_device() and device_del() calls > >> are shuffled to make sure that the unsol event is masked before > >> deleting the device. > >> > >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204565 > >> Signed-off-by: Takashi Iwai > >> Signed-off-by: Sasha Levin > > > >The upstream commit was reverted later by 246bb4aaa4f4, which has even > >Fixes tag pointing this. So please drop this. > > I'll drop it, thank you. > > >BTW, this is the second time AUTOSEL overlooked the existing revert. > >I'm afraid something is missing in the check. > > Usually it's the case that I check for fixes/reverts once I compile the > series, and again right before I queue it up to a stable tree. In > between fixes and reverts tend to sneak in just like in this case. > > In general, I also check the -rcs for fixes and reverts during their > review window, so while sometimes we send out mails with patches that > have a fix or revert upstream, they rarely make it into a released > stable kernel. IMO, it'd be great if you have some check before sending for reviews. The Fixes tag chain can be parsed relatively easily, after all. thanks, Takashi